Bug #32238
closed
Bugfix #28952 breaks sections in flexforms
0%
Description
The above bugfix breaks Flexforms sections.
The problem is due to the fact that the added decodeURIComponent() tries to decode an already decoded URI, resulting in a javascript error "Malformed URI sequence".
To reproduce use the attached flexform.
Files
Updated by Stefan Rotsch almost 13 years ago
Removing the obsolete call of unescape() on the already decoded output of decodeURIComponent() makes JS links on Flexform sections work again for me without re-introducing the bug mentioned in #28952.
I submitted a patch to review.typo3.org. As this is my first attempt of contribution, please be patient with me if I made any formal mistakes.
Updated by Gerrit Code Review almost 13 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7468
Updated by Ernesto Baschny almost 13 years ago
The solution seems fine as the unescape() is really superfluous. Please also consider bug #33377, which adds yet another layer of complexity, at least for TYPO3 4.5 LTS, where we also want to support non UTF-8 based backends. Any idea?
Updated by Ernesto Baschny almost 13 years ago
- Target version changed from 4.5.9 to 4.5.12
Updated by Gerrit Code Review almost 13 years ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/8885
Updated by Helmut Hummel almost 13 years ago
- Status changed from Under Review to Closed
closed as duplicate