Bug #32480: Form.css cannot be disabled - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #32480

closed

Form.css cannot be disabled

Added by Lorenz Ulrich over 12 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Form Framework

Target version:

Start date:

2011-12-12

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.6

PHP Version:

Tags:

Complexity:

medium

Is Regression:

Sprint Focus:

Description

Currently the frontend CSS file of the new form element is hardcoded and thus cannot be disabled.

Form.php:

    protected function setCss() {
        $GLOBALS['TSFE']->additionalHeaderData['tx_form_css'] =
            '<link rel="stylesheet" type="text/css" href="' .
            t3lib_extMgm::siteRelPath('form') .
            'Resources/Public/CSS/Form.css' .
            '" media="all" />';
    }

I would suggest to remove this method and the CSS include to the TypoScript setup in sysext/form/Configuration/TypoScript/setup.txt.

page.includeCSS.tx_form = typo3/sysext/form/Resources/Public/CSS/Form.css

Same for Confirmation.php.

If you agree with me, I would submit a request to Gerrit.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Lorenz Ulrich over 12 years ago

After thinking about it, I think it would be better to read out TypoScript configuration in the setCss method because we want to make sure that the CSS is only on pages that contain a form element.

Actions

Copy link

Updated by Steffen Gebert over 12 years ago

I start puking, when I see that code.. it totally circumvents most API. Yes, including it in the TS template should be cleaner!

Actions

Copy link

Updated by Oliver Hader over 12 years ago

Status changed from New to Accepted
Complexity changed from easy to medium

Agreed, Lorenz did you consider to fix this? ;-)

Actions

Copy link

Updated by Lorenz Ulrich over 12 years ago

Yes I did :-). And I think I'll fix it.

Actions

Copy link

Updated by Blogger about 12 years ago

This correction is resolved?

Actions

Copy link

Updated by Andreas Sauer about 12 years ago

Is there any way to circumvent the inclusion of the stylesheet this until it is resolved?
I don't want to poop on anybodies party, but i completely disagree with the contents of Form.css and want it gone.

Actions

Copy link

Updated by Lorenz Ulrich about 12 years ago

Since I missed feature freeze (and a TypoScript config is a feature) this can only go into 4.8 (6.0?). I need to setup a new installation for master before I can do it.

Actions

Copy link

Updated by Paul Fleischanderl almost 12 years ago

made progress?

Actions

Copy link

Updated by Gerrit Code Review almost 12 years ago

Status changed from Accepted to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11932

Actions

Copy link

#10

Updated by Lorenz Ulrich almost 12 years ago

As you can see, this change is pending in Gerrit. Now it's your work to test it and plusone it if it works. Thanks!

Actions

Copy link

#11

Updated by Gerrit Code Review almost 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11932

Actions

Copy link

#12

Updated by Gerrit Code Review almost 12 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11932

Actions

Copy link

#13

Updated by Gerrit Code Review over 11 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11932

Actions

Copy link

#14

Updated by Lorenz Ulrich over 11 years ago

Anyone annoyed by this: I think the latest changeset would be fine for merging, but I will not be able to push that since I'll be on a holiday now. Please merge it before feature freeze :-). Thanks.

Actions

Copy link

#15