Bug #32480
closed
Form.css cannot be disabled
Added by Lorenz Ulrich over 12 years ago.
Updated over 5 years ago.
Description
Currently the frontend CSS file of the new form element is hardcoded and thus cannot be disabled.
Form.php:
protected function setCss() {
$GLOBALS['TSFE']->additionalHeaderData['tx_form_css'] =
'<link rel="stylesheet" type="text/css" href="' .
t3lib_extMgm::siteRelPath('form') .
'Resources/Public/CSS/Form.css' .
'" media="all" />';
}
I would suggest to remove this method and the CSS include to the TypoScript setup in sysext/form/Configuration/TypoScript/setup.txt.
page.includeCSS.tx_form = typo3/sysext/form/Resources/Public/CSS/Form.css
Same for Confirmation.php.
If you agree with me, I would submit a request to Gerrit.
After thinking about it, I think it would be better to read out TypoScript configuration in the setCss method because we want to make sure that the CSS is only on pages that contain a form element.
I start puking, when I see that code.. it totally circumvents most API. Yes, including it in the TS template should be cleaner!
- Status changed from New to Accepted
- Complexity changed from easy to medium
Agreed, Lorenz did you consider to fix this? ;-)
Yes I did :-). And I think I'll fix it.
This correction is resolved?
Is there any way to circumvent the inclusion of the stylesheet this until it is resolved?
I don't want to poop on anybodies party, but i completely disagree with the contents of Form.css and want it gone.
Since I missed feature freeze (and a TypoScript config is a feature) this can only go into 4.8 (6.0?). I need to setup a new installation for master before I can do it.
- Status changed from Accepted to Under Review
As you can see, this change is pending in Gerrit. Now it's your work to test it and plusone it if it works. Thanks!
Anyone annoyed by this: I think the latest changeset would be fine for merging, but I will not be able to push that since I'll be on a holiday now. Please merge it before feature freeze :-). Thanks.
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF