Task #32994
closed
swfobject is included twice
Added by Christian Welzel almost 13 years ago.
Updated over 11 years ago.
Description
swfobject.js is included twice in TYPO3.
It is in
typo3/contrib/swfupload/plugins/swfupload.swfobject.js
typo3/contrib/swfupload/plugins/swfobject_license.txt
typo3/contrib/flashmedia/swfobject
typo3/contrib/flashmedia/swfobject/swfobject.js
It should only be included once.
- Subject changed from swfobject is included trice to swfobject is included twice
I discovered, that its not as easy as thought.
typo3/contrib/swfupload/plugins/swfupload.swfobject.js contains swfobject 2.1 but its more code than only swfobject. swfobject is embedded into the plugin code for swfupload.
typo3/contrib/flashmedia/swfobject/swfobject.js has swfobject 2.2.
everything under typo3/contrib is thirdparty so removing things by hand is not a good idea.
flvplayer.swf is not 3rd party.
But it really makes no sense to patch the files.
Moving up swfobject one level directly under contrib/ would make more clear, that there (in case somebody needs it). It would prevend multiple inclusion.
- Tracker changed from Bug to Task
- Target version deleted (
4.7.0)
- Status changed from New to Closed
The duplicated file has been removed in 6.1
Also available in: Atom
PDF