Bug #33137

CSS concatenation only working for files with media attribute set to "all"

Added by Christian Hellmuth over 9 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2012-01-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When using the typoscript option config.concatenateCss = 1 the default concatenation handler will only process those CSS files that either have set the media attribute to "all" or have not set a media attribute explicitly in the PAGE.includeCSS array.

It should work for all non-excluded files, meaning that a concatenated file for each media needs to be created (just like the extension scriptmerger does the job).


Related issues

Related to TYPO3 Core - Bug #40499: Concatenation of css files works only with media "all" or no mediaClosed2012-09-01

Actions
#1

Updated by Steffen Gebert over 9 years ago

  • Target version deleted (4.6.4)

Thanks for your report, sounds valid. I know, why I did not like this as core functionality.. :-( Too many special cases..

#2

Updated by Stefan Galinski over 8 years ago

  • Status changed from New to Accepted
#3

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19398

#4

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19398

#5

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19398

#6

Updated by Wouter Beeftink almost 8 years ago

What's the status of this issue?

#7

Updated by Bas van Beek over 7 years ago

This is issue is still occurring in TYPO3 6.2 LTS.

When including several CSS files by TypoScript they are only merged if you don't define "media=screen".

#8

Updated by Wouter Beeftink over 7 years ago

Just move to Grunt :-)

#9

Updated by Gerrit Code Review almost 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

#10

Updated by Georg Ringer almost 7 years ago

  • Is Regression set to No

how to test


config.concatenateCss = 1 

page.includeCSS {
  file1 = fileadmin/css/all-1.css
  file1.media = all

  file2 = fileadmin/css/print-1.css
  file2.media = print

  file3 = fileadmin/css/all-2.css
  file3.media = all

  file4 = fileadmin/css/print-2.css
  file4.media = print
}
#11

Updated by Gerrit Code Review almost 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

#12

Updated by Gerrit Code Review almost 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

#13

Updated by Gerrit Code Review about 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

#14

Updated by Gerrit Code Review about 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

#15

Updated by Gerrit Code Review about 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

#16

Updated by Gerrit Code Review about 6 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

#17

Updated by Gerrit Code Review about 6 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

#18

Updated by Gerrit Code Review about 6 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

#19

Updated by Gerrit Code Review about 6 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

#20

Updated by Georg Ringer about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#21

Updated by Benni Mack almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF