Project

General

Profile

Actions

Bug #33137

closed

CSS concatenation only working for files with media attribute set to "all"

Added by Christian Hellmuth almost 13 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2012-01-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When using the typoscript option config.concatenateCss = 1 the default concatenation handler will only process those CSS files that either have set the media attribute to "all" or have not set a media attribute explicitly in the PAGE.includeCSS array.

It should work for all non-excluded files, meaning that a concatenated file for each media needs to be created (just like the extension scriptmerger does the job).


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #40499: Concatenation of css files works only with media "all" or no mediaClosed2012-09-01

Actions
Actions #1

Updated by Steffen Gebert almost 13 years ago

  • Target version deleted (4.6.4)

Thanks for your report, sounds valid. I know, why I did not like this as core functionality.. :-( Too many special cases..

Actions #2

Updated by Stefan Galinski over 11 years ago

  • Status changed from New to Accepted
Actions #3

Updated by Gerrit Code Review over 11 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19398

Actions #4

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19398

Actions #5

Updated by Gerrit Code Review over 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19398

Actions #6

Updated by Wouter Beeftink about 11 years ago

What's the status of this issue?

Actions #7

Updated by Bas van Beek over 10 years ago

This is issue is still occurring in TYPO3 6.2 LTS.

When including several CSS files by TypoScript they are only merged if you don't define "media=screen".

Actions #8

Updated by Wouter Beeftink over 10 years ago

Just move to Grunt :-)

Actions #9

Updated by Gerrit Code Review about 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

Actions #10

Updated by Georg Ringer about 10 years ago

  • Is Regression set to No

how to test


config.concatenateCss = 1 

page.includeCSS {
  file1 = fileadmin/css/all-1.css
  file1.media = all

  file2 = fileadmin/css/print-1.css
  file2.media = print

  file3 = fileadmin/css/all-2.css
  file3.media = all

  file4 = fileadmin/css/print-2.css
  file4.media = print
}
Actions #11

Updated by Gerrit Code Review almost 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

Actions #12

Updated by Gerrit Code Review almost 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

Actions #13

Updated by Gerrit Code Review over 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

Actions #14

Updated by Gerrit Code Review over 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

Actions #15

Updated by Gerrit Code Review over 9 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

Actions #16

Updated by Gerrit Code Review over 9 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

Actions #17

Updated by Gerrit Code Review over 9 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

Actions #18

Updated by Gerrit Code Review over 9 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

Actions #19

Updated by Gerrit Code Review over 9 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/19398

Actions #20

Updated by Georg Ringer over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #21

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF