Bug #33392
closed
showHidden flag in tslib_fe is not "workspaces aware"
100%
Description
In tslib_fe the flag $this->showHiddenPage is set to true whenever the requested uid is a hidden page. However this code always looks at the original uid and not to the versioned overlay. When working with workspaces and adding new pages in draft, all placeholders have hidden set to 1. This means that showHiddenPage will always become true, and all hidden pages will be shown. This essentially breaks the rendering of menus etc., as all the menus will show all hidden pages too.
Updated by Ernesto Baschny almost 13 years ago
- Status changed from New to Accepted
This is indeed a problem that I can confirm (probably in all TYPO3 versions which have workspaces).
Probably not so easy to solve because this part of the code is very old (back from the beginnings from the workspaces, 2003-2004) and it's hard to change anything without having some side effects.
Thanks for your report so far, if you have any idea on how to solve it (if you have PHP knowledge), please go ahead.
Updated by Ernesto Baschny almost 13 years ago
How to reproduce in the intro-package:
1) Hide any page in the navigation (in live mode)
2) Switch to some Workspace
3) Create more pages anywhere and "unhide" them (still in this Workspace)
4) Preview one of these new pages in the Frontend
5) The new pages added to the workspace now appear but also the hidden page from Live mode (hidden in 1) also wrongly appear (and you can actually even click and preview them!)
Updated by Ernesto Baschny almost 13 years ago
Uncommenting class.tslib_fe.php line 793 ($this->showHiddenPage = 1) apparently makes it behave correctly, but I have no idea of the side effects of it. :)
Updated by Gerrit Code Review almost 13 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/8676
Updated by Gerrit Code Review almost 13 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8720
Updated by Gerrit Code Review almost 13 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8720
Updated by Gerrit Code Review almost 13 years ago
Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/8676
Updated by Gerrit Code Review almost 13 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8720
Updated by Gerrit Code Review almost 13 years ago
Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/8676
Updated by Gerrit Code Review almost 13 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8720
Updated by Gerrit Code Review almost 13 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8720
Updated by Gerrit Code Review over 12 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8720
Updated by Gerrit Code Review over 12 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8720
Updated by Gerrit Code Review over 12 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8720
Updated by Gerrit Code Review over 12 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8720
Updated by Gerrit Code Review over 12 years ago
Patch set 10 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8720
Updated by Bart Dubelaar over 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 34eee3a3cf013d216d47ebe69e7ca75a38fe5224.
Updated by Gerrit Code Review over 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12802
Updated by Gerrit Code Review over 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12803
Updated by Gerrit Code Review over 12 years ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12804
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14357
Updated by Steffen Ritter about 12 years ago
- Status changed from Under Review to Resolved
Applied in changeset 241e31dcf3407e708aa817dc0f00f06ca8b84103.
Updated by Gerrit Code Review about 12 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12804
Updated by Gerrit Code Review about 12 years ago
Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12803
Updated by Gerrit Code Review about 12 years ago
Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12802
Updated by Bart Dubelaar about 12 years ago
- Status changed from Under Review to Resolved
Applied in changeset b2e2df1ea04a5a4f49403de36ae8a0aee9afb92e.
Updated by