Bug #34695
closedmissing parameter for implode in showpic.php
100%
Description
implode requires 2 parameters, only one is given in showpic.php:
$this->parametersEncoded = implode($parametersArray);
Updated by Jigal van Hemert about 12 years ago
- Status changed from New to Needs Feedback
- Assignee set to Jigal van Hemert
According to PHP documentation [1] the 'glue' parameter became optional in 4.3.0; it's not needed if it's empty.
Have you encountered errors or other problems?
Updated by Simon Schaufelberger about 12 years ago
phpstorm does not like it and:
This is not the preferred usage of implode() as glue would be the second parameter and thus, the bad prototype would be used.
but there were no errors so far.
Updated by Oliver Hader about 12 years ago
- Status changed from Needs Feedback to Accepted
- Priority changed from Must have to Should have
- Target version set to 4.5.14
Updated by Gerrit Code Review almost 12 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10192
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10193
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/10194
Updated by Gerrit Code Review almost 12 years ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/10195
Updated by Jigal van Hemert almost 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f9fe38ee604e9985b898ef590e9acd966d1dc92a.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed