Bug #34695

missing parameter for implode in showpic.php

Added by Simon Schaufelberger over 9 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2012-03-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

implode requires 2 parameters, only one is given in showpic.php:

$this->parametersEncoded = implode($parametersArray);
#1

Updated by Jigal van Hemert over 9 years ago

  • Status changed from New to Needs Feedback
  • Assignee set to Jigal van Hemert

According to PHP documentation [1] the 'glue' parameter became optional in 4.3.0; it's not needed if it's empty.

Have you encountered errors or other problems?

[1] http://www.php.net/implode

#2

Updated by Simon Schaufelberger over 9 years ago

phpstorm does not like it and:

This is not the preferred usage of implode() as glue would be the second parameter and thus, the bad prototype would be used.

but there were no errors so far.

#3

Updated by Oliver Hader over 9 years ago

  • Status changed from Needs Feedback to Accepted
  • Priority changed from Must have to Should have
  • Target version set to 4.5.14
#4

Updated by Gerrit Code Review about 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10192

#5

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10193

#6

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/10194

#7

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/10195

#8

Updated by Jigal van Hemert about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF