Bug #34695

missing parameter for implode in showpic.php

Added by Simon Schaufelberger almost 8 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2012-03-09
Due date:
% Done:

100%

TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

implode requires 2 parameters, only one is given in showpic.php:

$this->parametersEncoded = implode($parametersArray);

Associated revisions

Revision bcd5269b (diff)
Added by Jigal van Hemert over 7 years ago

[BUGFIX] missing parameter for implode

Use the preferred syntax for implode()

Change-Id: Id5db3a209903978979eba971f7f53180a850289a
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #34695
Reviewed-on: http://review.typo3.org/10192
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Revision 4a2995fd (diff)
Added by Jigal van Hemert over 7 years ago

[BUGFIX] missing parameter for implode

Use the preferred syntax for implode()

Change-Id: I8ebc880f797b379f35924641e3d0b11f0e2ec34e
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #34695
Reviewed-on: http://review.typo3.org/10193
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Revision f4e9e59b (diff)
Added by Jigal van Hemert over 7 years ago

[BUGFIX] missing parameter for implode

Use the preferred syntax for implode()

Change-Id: Ieb20713e16139920b1622334ddebcf8e4eb8267f
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #34695
Reviewed-on: http://review.typo3.org/10194
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Revision f9fe38ee (diff)
Added by Jigal van Hemert over 7 years ago

[BUGFIX] missing parameter for implode

Use the preferred syntax for implode()

Change-Id: I0103b3947b73050e99fcfb3cdacb14ea2b873d8b
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #34695
Reviewed-on: http://review.typo3.org/10195
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

History

#1 Updated by Jigal van Hemert almost 8 years ago

  • Status changed from New to Needs Feedback
  • Assignee set to Jigal van Hemert

According to PHP documentation [1] the 'glue' parameter became optional in 4.3.0; it's not needed if it's empty.

Have you encountered errors or other problems?

[1] http://www.php.net/implode

#2 Updated by Simon Schaufelberger almost 8 years ago

phpstorm does not like it and:

This is not the preferred usage of implode() as glue would be the second parameter and thus, the bad prototype would be used.

but there were no errors so far.

#3 Updated by Oliver Hader almost 8 years ago

  • Status changed from Needs Feedback to Accepted
  • Priority changed from Must have to Should have
  • Target version set to 4.5.14

#4 Updated by Gerrit Code Review over 7 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10192

#5 Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10193

#6 Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/10194

#7 Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/10195

#8 Updated by Jigal van Hemert over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF