Bug #34695
closed
missing parameter for implode in showpic.php
Added by Simon Schaufelberger about 12 years ago.
Updated over 6 years ago.
Description
implode requires 2 parameters, only one is given in showpic.php:
$this->parametersEncoded = implode($parametersArray);
- Status changed from New to Needs Feedback
- Assignee set to Jigal van Hemert
According to PHP documentation [1] the 'glue' parameter became optional in 4.3.0; it's not needed if it's empty.
Have you encountered errors or other problems?
[1] http://www.php.net/implode
phpstorm does not like it and:
This is not the preferred usage of implode() as glue would be the second parameter and thus, the bad prototype would be used.
but there were no errors so far.
- Status changed from Needs Feedback to Accepted
- Priority changed from Must have to Should have
- Target version set to 4.5.14
- Status changed from Accepted to Under Review
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF