Bug #36308
closedCardLayout, path of css file is wrongly calculated
100%
Description
end of backend.php:
if (is_array($moduleConfig['cssFiles'])) { foreach ($moduleConfig['cssFiles'] as $cssFileName => $cssFile) { $TYPO3backend->addCssFile($name, t3lib_div::getFileAbsFileName($cssFile)); } }
should be
if (is_array($moduleConfig['cssFiles'])) { foreach ($moduleConfig['cssFiles'] as $cssFileName => $cssFile) { $files = array(t3lib_div::getFileAbsFileName($cssFile)); $files = t3lib_div::removePrefixPathFromList($files, PATH_site); $TYPO3backend->addCssFile($name, t3lib_div::getFileAbsFileName($files[0])); } }
Otherwise the code tries to load the local file :(
related to 4.7 and master!
Funny, can't assign the issue to me :(
Files
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10689
Updated by Kay Strobach over 12 years ago
- File dashboard.zip dashboard.zip added
see for more details
http://wiki.typo3.org/Extension_Development,_native_ExtJS_Modules
use attachment for testing (early alpha extension, not for production usage!)
Updated by Tolleiv Nietsch over 12 years ago
Well thanks for the input ... I can't really see what's wrong. Would you mind to add a description?
Updated by Kay Strobach over 12 years ago
The dashboard extension adds some html like
<link rel="stylesheet" type="text/css" href="D:/www/t3-trunk/typo3conf/ext/dashboard/Resources/Public/Stylesheet/dashboard.css" media="all">
To the output of the backend.php
while the output should be
<link rel="stylesheet" type="text/css" href="../typo3conf/ext/dashboard/Resources/Public/Stylesheet/dashboard.css" media="all">
The file is configured in the ext_tables.php
t3lib_extMgm::addExtJSModule( $_EXTKEY, 'user', 'dashboard', '', array( //additional config 'access' => 'user,group', //'icon' => 'EXT:sitemgr/Resources/Public/Images/Backend/mod1/moduleicon.gif', 'labels' => 'dada LLL:EXT:dashboard/Ressources/Private/Language/dashboard.xml:modTitle', 'jsFiles' => array( 'EXT:dashboard/Resources/Public/JavaScript/dashboard.js', 'EXT:dashboard/Resources/Public/JavaScript/ux/Ext.ux.widgetPortal.js', 'EXT:dashboard/Resources/Public/JavaScript/ux/Ext.ux.widgetPortalColumn.js', 'EXT:dashboard/Resources/Public/JavaScript/ux/Ext.ux.widgetPortalWidget.js', ), 'cssFiles' => array( 'EXT:dashboard/Resources/Public/Stylesheet/dashboard.css' ) ) );
See in the above snippet
'cssFiles' => array( 'EXT:dashboard/Resources/Public/Stylesheet/dashboard.css' )
Regards
Kay
Updated by Gerrit Code Review over 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10689
Updated by Gerrit Code Review over 12 years ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12175
Updated by Kay Strobach over 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 45bf97be1448c972e02d26b0e6be6ddb76ddc075.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed