Project

General

Profile

Actions

Bug #36597

closed

colorspace change in imagemagick 6.7.5 from RGB to sRGB

Added by Jan Perdoch about 12 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Image Cropping
Target version:
-
Start date:
2012-04-26
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

After upgrading imagemagick to new version are all new generated images darker as uploaded. Problem is caused by changing colorspace in imagemagick (probably from version 6.7.0). There is simple fix: just change (3 times) -colorspace RGB to -colorspace sRGB in class.t3lib_stdgraphic.php. But nicer will be to have version depending switch or possibility change colorspace in install tool.

our conf:
php 5.3.5
imagemagick 6.7.5-5
typo3 4.5.14 and 4.5.15

It seems, that same problem will be on 4.6 and 4.7 too, because they use also -colorspace RGB.


Files

typo3-images-image-processing.PNG (302 KB) typo3-images-image-processing.PNG Problem is seen also in install tool. Jan Perdoch, 2012-04-26 10:51
36597.diff (2.58 KB) 36597.diff Bernd Niehues, 2012-11-07 16:04
Actions #1

Updated by Jan Perdoch about 12 years ago

Problem is seen also in install tool.

Actions #2

Updated by Alex no-lastname-given over 11 years ago

Bug still exists on this configuration:
php 5.3.13
imagemagick 6.7.8-6
typo3 4.7.4

Replacing RGB to sRGB (3 times) helps, many thanks to Jan Perdoch

Actions #3

Updated by Andreas Mayer over 11 years ago

  • Priority changed from Should have to Must have
I had to upgrade ImageMagick because the old versions had security issues. Can confirm this bug with:
  • Typo3/4.7.4
  • ImageMagick-nox11-6.7.9.4
Actions #5

Updated by Fritz-Michael Gschwantner over 11 years ago

Came across this problem as well. Config:

php 5.4.7
ImageMagick 6.8.0.4
Typo3 4.5.20

I changed the IM parameters in the source as described above, seemed more straight forward to me in this case, than trying to create wrappers etc. ;). Hopefully this gets fixed in Typo3's source too at some point

Actions #6

Updated by Bernd Niehues over 11 years ago

I tried to solve the problem by identifing the ImageMagick version with the identify command, which worked well for me. Maybe there is a better solution. But for now here is my one. The diff was created with a 4.7.4 core.

Actions #7

Updated by Andreas Mayer over 11 years ago

Maybe all these Typo3 ImageMagick settings (negate mask, mask inv. etc) could be replaced by an "ImageMagick version" setting that contains the full version info (not just major number)? All further settings could be derived from this one.

Actions #8

Updated by Kay Strobach over 11 years ago

Maybe all these Typo3 ImageMagick settings (negate mask, mask inv. etc) could be replaced by an "ImageMagick version" setting that contains the full version info (not just major number)? All further settings could be derived from this one.

I would definitly prefer a version based preset, that all manual settings :D -> the manual should be still applyable in the Localconfiguration :D

Actions #9

Updated by Gerrit Code Review over 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

Actions #10

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

Actions #11

Updated by Gerrit Code Review over 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

Actions #12

Updated by Gerrit Code Review over 11 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

Actions #13

Updated by Gerrit Code Review over 11 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

Actions #14

Updated by Gerrit Code Review over 11 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

Actions #15

Updated by Gerrit Code Review over 11 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

Actions #16

Updated by Gerrit Code Review over 11 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

Actions #17

Updated by Gerrit Code Review over 11 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

Actions #18

Updated by Gerrit Code Review over 11 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

Actions #19

Updated by Gerrit Code Review over 11 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

Actions #20

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/18804

Actions #21

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/18804

Actions #22

Updated by Gerrit Code Review over 11 years ago

Patch set 3 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/18804

Actions #23

Updated by Anja Leichsenring over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #24

Updated by Gerrit Code Review about 11 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/19724

Actions #25

Updated by Gerrit Code Review about 11 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19725

Actions #26

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/19724

Actions #27

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19725

Actions #28

Updated by Gerrit Code Review about 11 years ago

Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19725

Actions #29

Updated by Gerrit Code Review about 11 years ago

Patch set 4 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19725

Actions #30

Updated by Gerrit Code Review about 11 years ago

Patch set 5 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19725

Actions #31

Updated by Anja Leichsenring about 11 years ago

  • Status changed from Under Review to Resolved
Actions #32

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF