Bug #36597

colorspace change in imagemagick 6.7.5 from RGB to sRGB

Added by Jan Perdoch over 4 years ago. Updated about 3 years ago.

Status:Resolved Start date:2012-04-26
Priority:Must have Due date:
Assigned To:- % Done:

100%

Category:Image Generation Spent time: -
Target version:-
TYPO3 Version:4.5 Complexity:
PHP Version: Is Regression:
Tags: Sprint Focus:

Description

After upgrading imagemagick to new version are all new generated images darker as uploaded. Problem is caused by changing colorspace in imagemagick (probably from version 6.7.0). There is simple fix: just change (3 times) -colorspace RGB to -colorspace sRGB in class.t3lib_stdgraphic.php. But nicer will be to have version depending switch or possibility change colorspace in install tool.

our conf:
php 5.3.5
imagemagick 6.7.5-5
typo3 4.5.14 and 4.5.15

It seems, that same problem will be on 4.6 and 4.7 too, because they use also -colorspace RGB.

typo3-images-image-processing.PNG - Problem is seen also in install tool. (301.8 kB) Jan Perdoch, 2012-04-26 10:51

36597.diff Magnifier (2.6 kB) Bernd Niehues, 2012-11-07 16:04

Associated revisions

Revision be4887e7
Added by Anja Leichsenring over 3 years ago

[BUGFIX] Allow Setting colorspace in the Install Tool.

Some versions of Imagemagick (6.7.0 and above) use the sRGB colorspace
instead RGB as before. This results in darker images after processing,
because TYPO3 hardcoded the RGB colorspace in graphical functions.

This patch introduces a setting in the GFX part of the Install Tool,
lets the user choose the sufficient colorspace.
This selection is used in graphical functions.

Additionaly a hint on the setting was added to the Image Processing Test
'Read Images' in the Install Tool.

Fixes: #36597
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: I50a26c414705afa3177a2f12fc3bb4532c2d0f7f
Reviewed-on: https://review.typo3.org/17474
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 64f5f361
Added by Anja Leichsenring over 3 years ago

[BUGFIX] Allow Setting colorspace in the Install Tool.

Some versions of Imagemagick (6.7.0 and above) use the sRGB colorspace
instead RGB as before. This results in darker images after processing,
because TYPO3 hardcoded the RGB colorspace in graphical functions.

This patch introduces a setting in the GFX part of the Install Tool,
lets the user choose the sufficient colorspace.
This selection is used in graphical functions.

Additionaly a hint on the setting was added to the Image Processing Test
'Read Images' in the Install Tool.

Fixes: #36597
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: I50a26c414705afa3177a2f12fc3bb4532c2d0f7f
Reviewed-on: https://review.typo3.org/18804
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision b07277d5
Added by Anja Leichsenring over 3 years ago

[BUGFIX] Allow Setting colorspace in the Install Tool.

Some versions of Imagemagick (6.7.0 and above) use the sRGB colorspace
instead RGB as before. This results in darker images after processing,
because TYPO3 hardcoded the RGB colorspace in graphical functions.

This patch introduces a setting in the GFX part of the Install Tool,
lets the user choose the sufficient colorspace.
This selection is used in graphical functions.

Additionaly a hint on the setting was added to the Image Processing Test
'Read Images' in the Install Tool.

Fixes: #36597
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: I50a26c414705afa3177a2f12fc3bb4532c2d0f7f
Reviewed-on: https://review.typo3.org/19725
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Revision 74fd4b8f
Added by Anja Leichsenring over 3 years ago

[BUGFIX] Allow Setting colorspace in the Install Tool.

Some versions of Imagemagick (6.7.0 and above) use the sRGB colorspace
instead RGB as before. This results in darker images after processing,
because TYPO3 hardcoded the RGB colorspace in graphical functions.

This patch introduces a setting in the GFX part of the Install Tool,
lets the user choose the sufficient colorspace.
This selection is used in graphical functions.

Additionaly a hint on the setting was added to the Image Processing Test
'Read Images' in the Install Tool.

Fixes: #36597
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: I50a26c414705afa3177a2f12fc3bb4532c2d0f7f
Reviewed-on: https://review.typo3.org/19724
Reviewed-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

History

#1 Updated by Jan Perdoch over 4 years ago

Problem is seen also in install tool.

#2 Updated by Alex almost 4 years ago

Bug still exists on this configuration:
php 5.3.13
imagemagick 6.7.8-6
typo3 4.7.4

Replacing RGB to sRGB (3 times) helps, many thanks to Jan Perdoch

#3 Updated by Andreas Mayer almost 4 years ago

  • Priority changed from Should have to Must have
I had to upgrade ImageMagick because the old versions had security issues. Can confirm this bug with:
  • Typo3/4.7.4
  • ImageMagick-nox11-6.7.9.4

#5 Updated by Fritz-Michael Gschwantner over 3 years ago

Came across this problem as well. Config:

php 5.4.7
ImageMagick 6.8.0.4
Typo3 4.5.20

I changed the IM parameters in the source as described above, seemed more straight forward to me in this case, than trying to create wrappers etc. ;). Hopefully this gets fixed in Typo3's source too at some point

#6 Updated by Bernd Niehues over 3 years ago

I tried to solve the problem by identifing the ImageMagick version with the identify command, which worked well for me. Maybe there is a better solution. But for now here is my one. The diff was created with a 4.7.4 core.

#7 Updated by Andreas Mayer over 3 years ago

Maybe all these Typo3 ImageMagick settings (negate mask, mask inv. etc) could be replaced by an "ImageMagick version" setting that contains the full version info (not just major number)? All further settings could be derived from this one.

#8 Updated by Kay Strobach over 3 years ago

Maybe all these Typo3 ImageMagick settings (negate mask, mask inv. etc) could be replaced by an "ImageMagick version" setting that contains the full version info (not just major number)? All further settings could be derived from this one.

I would definitly prefer a version based preset, that all manual settings :D -> the manual should be still applyable in the Localconfiguration :D

#9 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

#10 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

#11 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

#12 Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

#13 Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

#14 Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

#15 Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

#16 Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

#17 Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

#18 Updated by Gerrit Code Review over 3 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

#19 Updated by Gerrit Code Review over 3 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17474

#20 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/18804

#21 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/18804

#22 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/18804

#23 Updated by Anja Leichsenring over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#24 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/19724

#25 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19725

#26 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/19724

#27 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19725

#28 Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19725

#29 Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19725

#30 Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/19725

#31 Updated by Anja Leichsenring over 3 years ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF