Bug #36894: [felogin] Wrong action url when nested array is passed - TYPO3 Core - TYPO3 Forge

Actions

Bug #36894

closed

[felogin] Wrong action url when nested array is passed

Added by Tymoteusz Motylewski over 12 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

-

Category:

-

Target version:

-

Start date:

2012-05-06

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.6

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

If you have login form on page with url like this:
index.php?id=10&L=3&tx_someext[@widget_0][currentPage]=3

Action url of login form will point to:
index.php?id=10&L=3&tx_someext[@widget_0]=Array

The problem is in method tx_felogin_pi1->getPreserveGetVars() (called from getPageLink() ).
This method assumes that no nested arrays are passed as parameter.

$params .= '&' . $key . '[' . $key1 . ']=' . $val1;

Files

Download all files

felogin.patch (2.03 KB) felogin.patch	felogin Patch	Horst Prote, 2012-05-23 16:30
felogin.patch (2.18 KB) felogin.patch		Horst Prote, 2012-05-25 15:11

Related issues 3 (0 open — 3 closed)

Actions

#1

Updated by Horst Prote over 12 years ago

File felogin.patch felogin.patch added

I hit this and the related issue #23324 some days ago.

Here's my patch for both.

Actions

#2

Updated by Markus Klein over 12 years ago

Thank you Horst.
Would you mind pushing your patch to gerrit?

If you need more information on this, have a look at:
http://wiki.typo3.org/Contribution_Walkthrough_Tutorials

Actions

#3

Updated by Horst Prote over 12 years ago

File felogin.patch felogin.patch added

Markus Klein wrote:

Would you mind pushing your patch to gerrit?

If you need more information on this, have a look at:
http://wiki.typo3.org/Contribution_Walkthrough_Tutorials

I read the tutorial and think it's to complicated for me doing a quick "pushing the patch" besides my normal work. Maybe I'll find the time in one or two weeks. But I don't mind if anybody else pushes my patch to gerrit.

By the way my first patch generated a Log entry each time

$var[0]

runs empty. Here's the updated patch.

Actions

#4

Updated by Gerrit Code Review over 12 years ago

Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11642

Actions

#5

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11642

Actions

#6

Updated by Gerrit Code Review over 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#7

Updated by Gerrit Code Review over 12 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#8

Updated by Gerrit Code Review over 12 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#9

Updated by Gerrit Code Review over 12 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#10

Updated by Gerrit Code Review over 12 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#11

Updated by Gerrit Code Review about 12 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#12

Updated by Gerrit Code Review about 12 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#13

Updated by Gerrit Code Review about 12 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#14

Updated by Gerrit Code Review about 12 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#15

Updated by Gerrit Code Review about 12 years ago

Patch set 12 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#16

Updated by Gerrit Code Review about 12 years ago

Patch set 13 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#17

Updated by Gerrit Code Review about 12 years ago

Patch set 14 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#18

Updated by Gerrit Code Review about 12 years ago

Patch set 15 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#19

Updated by Gerrit Code Review about 12 years ago

Patch set 16 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#20

Updated by Gerrit Code Review about 12 years ago

Patch set 17 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

Actions

#21

Updated by Jigal van Hemert about 12 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset a0f4d13c9f53431a62845bbad31ff11bc5d5c2ef.

Actions

#22

Updated by Gerrit Code Review about 12 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/16452

Actions

#23

Updated by Gerrit Code Review almost 12 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/16452

Actions

#24

Updated by Jigal van Hemert almost 12 years ago

Status changed from Under Review to Resolved

Applied in changeset 9eca09b08b257fbdcc4053d88d1df3feeb9afd66.

Actions

#25

Updated by Benni Mack about 6 years ago

Status changed from Resolved to Closed

Actions

Also available in: Atom PDF