Bug #36894

[felogin] Wrong action url when nested array is passed

Added by Tymoteusz Motylewski over 8 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-05-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you have login form on page with url like this:
index.php?id=10&L=3&tx_someext[@widget_0][currentPage]=3

Action url of login form will point to:
index.php?id=10&L=3&tx_someext[@widget_0]=Array

The problem is in method tx_felogin_pi1->getPreserveGetVars() (called from getPageLink() ).
This method assumes that no nested arrays are passed as parameter.

$params .= '&' . $key . '[' . $key1 . ']=' . $val1;


Files

felogin.patch (2.03 KB) felogin.patch felogin Patch Horst Prote, 2012-05-23 16:30
felogin.patch (2.18 KB) felogin.patch Horst Prote, 2012-05-25 15:11

Related issues

Related to TYPO3 Core - Bug #23324: getPreserveGetVars does not work as expectedClosed2010-07-31

Actions
Related to TYPO3 Core - Bug #19938: warning: in_array wrong datatypeClosed2009-01-30

Actions
Has duplicate TYPO3 Core - Bug #48005: getPreserveGetVars does not work with nested arraysRejected2013-05-07

Actions
#1

Updated by Horst Prote over 8 years ago

I hit this and the related issue #23324 some days ago.

Here's my patch for both.

#2

Updated by Markus Klein over 8 years ago

Thank you Horst.
Would you mind pushing your patch to gerrit?

If you need more information on this, have a look at:
http://wiki.typo3.org/Contribution_Walkthrough_Tutorials

#3

Updated by Horst Prote over 8 years ago

Markus Klein wrote:

Would you mind pushing your patch to gerrit?

If you need more information on this, have a look at:
http://wiki.typo3.org/Contribution_Walkthrough_Tutorials

I read the tutorial and think it's to complicated for me doing a quick "pushing the patch" besides my normal work. Maybe I'll find the time in one or two weeks. But I don't mind if anybody else pushes my patch to gerrit.

By the way my first patch generated a Log entry each time

$var[0]
runs empty. Here's the updated patch.

#4

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11642

#5

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11642

#6

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#7

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#8

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#9

Updated by Gerrit Code Review over 8 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#10

Updated by Gerrit Code Review over 8 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#11

Updated by Gerrit Code Review about 8 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#12

Updated by Gerrit Code Review about 8 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#13

Updated by Gerrit Code Review about 8 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#14

Updated by Gerrit Code Review about 8 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#15

Updated by Gerrit Code Review about 8 years ago

Patch set 12 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#16

Updated by Gerrit Code Review about 8 years ago

Patch set 13 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#17

Updated by Gerrit Code Review about 8 years ago

Patch set 14 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#18

Updated by Gerrit Code Review about 8 years ago

Patch set 15 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#19

Updated by Gerrit Code Review about 8 years ago

Patch set 16 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#20

Updated by Gerrit Code Review about 8 years ago

Patch set 17 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7638

#21

Updated by Jigal van Hemert about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#22

Updated by Gerrit Code Review about 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/16452

#23

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/16452

#24

Updated by Jigal van Hemert almost 8 years ago

  • Status changed from Under Review to Resolved
#25

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF