Bug #37065

Workspace preview (FE) shows duplicate records

Added by Thorsten Kahler almost 8 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2012-05-10
Due date:
% Done:

100%

TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Sprint Focus:

Description

When in workspace preview versioned records, which are selected by any relation (except uid or pid) are shown twice: the original record and the versioned record.

This is caused by a wrong condition in t3lib_pageSelect::enableFields(): the selection on pid<>-1 should only be added if parameter $noVersionPreview is false. The parameter is only set to true to retrieve version overlays of specific records (see t3lib_pageSelect::getWorkspaceVersionOfRecord()).

Steps to reproduce:

  1. Install (and configure) EXT:blog_example
  2. create blog record (live)
  3. create blog post record (live)
  4. switch to any workspace
  5. edit blog post (workspace)
  6. open preview of page containing "list of blogs" plugin

This shows the blog created above containing two blog posts (in workspace frame).


Related issues

Related to TYPO3 Core - Bug #37209: Workspace preview shows pages changes from all workspaces Closed 2012-05-16
Related to TYPO3 Core - Task #54948: swap workspace won't reset t3ver_wsid New 2014-01-13

Associated revisions

Revision a81a5816 (diff)
Added by Timo Webler over 6 years ago

[BUGFIX] Don't show duplicates in workspace preview

Fixed workspace filters in case of workspace preview
in TYPO3\CMS\Frontend\Page\PageRepository::enableFields().

Additionally cleared up the corresponding comments.

Change-Id: I088928a88cb673f18f218ef691a6c528019317c0
Fixes: #37065
Releases: 6.2, 6.1, 6.0, 4.5
Reviewed-on: https://review.typo3.org/11127
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Revision 3ac3429a (diff)
Added by Timo Webler over 6 years ago

[BUGFIX] Don't show duplicates in workspace preview

Fixed workspace filters in case of workspace preview
in TYPO3\CMS\Frontend\Page\PageRepository::enableFields().

Additionally cleared up the corresponding comments.

Change-Id: I088928a88cb673f18f218ef691a6c528019317c0
Fixes: #37065
Releases: 6.2, 6.1, 6.0, 4.5
Reviewed-on: https://review.typo3.org/24008
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Revision f561b99c (diff)
Added by Timo Webler over 6 years ago

[BUGFIX] Don't show duplicates in workspace preview

Fixed workspace filters in case of workspace preview
in TYPO3\CMS\Frontend\Page\PageRepository::enableFields().

Additionally cleared up the corresponding comments.

Change-Id: I088928a88cb673f18f218ef691a6c528019317c0
Fixes: #37065
Releases: 6.2, 6.1, 6.0, 4.5
Reviewed-on: https://review.typo3.org/24009
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Revision d114ddb3 (diff)
Added by Timo Webler over 6 years ago

[BUGFIX] Don't show duplicates in workspace preview

Fixes workspace filter conditions in case of workspace preview in
t3lib_pageSelect::enableFields().

Additionally cleared up the corresponding comments.

Change-Id: I088928a88cb673f18f218ef691a6c528019317c0
Fixes: #37065
Releases: 6.2, 6.1, 6.0, 4.5
Reviewed-on: https://review.typo3.org/24075
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

History

#1 Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11127

#2 Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11127

#3 Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11127

#4 Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11127

#5 Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11127

#6 Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11127

#7 Updated by Gerrit Code Review over 7 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11127

#8 Updated by Gerrit Code Review about 7 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/11127

#9 Updated by Gerrit Code Review over 6 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/11127

#10 Updated by Gerrit Code Review over 6 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/11127

#11 Updated by Gerrit Code Review over 6 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/11127

#12 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/24008

#13 Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/24009

#14 Updated by Timo Webler over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#15 Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/24075

#16 Updated by Timo Webler over 6 years ago

  • Status changed from Under Review to Resolved

#17 Updated by Michael Voehringer about 6 years ago

Found some problem where this patch break the preview in the workspace. I opened a followup bug to this ticket, see #54948

#18 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF