Bug #39820: unnecessary moveNode in class.t3lib_tree_pagetree_commands.php createNode() - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Watchers (2)

Michael Stucki
Steffen Gebert

Actions

Copy link

Bug #39820

closed

unnecessary moveNode in class.t3lib_tree_pagetree_commands.php createNode()

Added by Tobias Schultheiss over 12 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Pagetree

Target version:

Start date:

2012-08-15

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.6

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

On a Typo3 4.6.10 installation i had the problem that the creation of a new page via drag&drop always timed out. A Tracking revealed that the creation of the new page took over 100 Seconds (thats pretty ugly but another issue). I finally tracked the bad Performance to the function createNode() in t3lib/tree/pagetree/class.t3lib_tree_pagetree_commands.php.
In said function is a comparison:
if ($parentNode->getWorkspaceId() !== $targetId) {
self::moveNode($node, $targetId);
}
which fails although both ids are the same. After i did a typecast to int on both of the ids, the comparison worked, the moveNode wasn't executed anymore and the duration fell to ~10 Seconds.

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #55768: Drag & drop in Workspaces moves live page

Closed

Thorsten Kahler

2014-02-07

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Steffen Gebert over 12 years ago

Oh, great improvement, Tobias! Thanks a lot.

Would you like to create a patch and send this into the review workflow? see http://wiki.typo3.org/Contribution_Walkthrough_Tutorials.

If you have any trouble, just ask!

Actions

Copy link

Updated by Gerrit Code Review over 12 years ago

Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13808

Actions

Copy link

Updated by Tobias Schultheiss over 12 years ago

Gerrit Code Review wrote:

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13808

Ok, first time i used git and i got mail from mr. jenkins.
what have i done wrong?

Actions

Copy link

Updated by Tobias Schultheiss over 12 years ago

Tobias Schultheiss wrote:

Gerrit Code Review wrote:

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13808

Ok, first time i used git and i got mail from mr. jenkins.
what have i done wrong?

seems i had mixed up some submodule pointers.
i made a new clone and changed the code again, this time it seems the pointers are all right.
do i just have to push the patch again?

Actions

Copy link

Updated by Steffen Gebert over 12 years ago

Hi Tobias,

sorry, I was on holiday, but Michi Stucki should have taken over (he promised to substitute myself).
But thanks a lot for digging into Git, I appreciate it!

To upload an updated version, please include this line in the commit message:

Change-Id: I702ccb71dcf91063012eb77091f5982661ee3afd

Otherwise a new change request will be created (which wouldn't be too dramatic).

We have a Troubleshooting page in the wiki, which can help you with the submodule problems: http://wiki.typo3.org/TroubleShooting_(Git)

And here's a tutorial, how you can upload an updated patch set: http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine#Improving_the_patch_and_uploading_a_new_Patch_Set

If I can help you, please post again. Will be available the next days!

Steffen

Actions

Copy link

Updated by Michael Stucki over 12 years ago

@Steffen: I'm looking at those issues right now, sorry that I couldn't do it before.

Actions

Copy link

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13808

Actions

Copy link

Updated by Gerrit Code Review over 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13808

Actions

Copy link

Updated by Tobias Schultheiss over 12 years ago

Steffen Gebert wrote:

Hi Tobias,

sorry, I was on holiday, but Michi Stucki should have taken over (he promised to substitute myself).
But thanks a lot for digging into Git, I appreciate it!

To upload an updated version, please include this line in the commit message:
[...]

Otherwise a new change request will be created (which wouldn't be too dramatic).

We have a Troubleshooting page in the wiki, which can help you with the submodule problems: http://wiki.typo3.org/TroubleShooting_(Git)

And here's a tutorial, how you can upload an updated patch set: http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine#Improving_the_patch_and_uploading_a_new_Patch_Set

If I can help you, please post again. Will be available the next days!

Steffen

Hi Steffen,

thanks for the resources and your assistance/comments (inspired me to share ... although i had to wait for the answer; I begrudge anyone his vacation), I think I managed to push it now correctly.

Actions

Copy link

#10