Project

General

Profile

Actions

Bug #39820

closed

unnecessary moveNode in class.t3lib_tree_pagetree_commands.php createNode()

Added by Tobias Schultheiss about 10 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Pagetree
Target version:
-
Start date:
2012-08-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

On a Typo3 4.6.10 installation i had the problem that the creation of a new page via drag&drop always timed out. A Tracking revealed that the creation of the new page took over 100 Seconds (thats pretty ugly but another issue). I finally tracked the bad Performance to the function createNode() in t3lib/tree/pagetree/class.t3lib_tree_pagetree_commands.php.
In said function is a comparison:
if ($parentNode->getWorkspaceId() !== $targetId) {
self::moveNode($node, $targetId);
}
which fails although both ids are the same. After i did a typecast to int on both of the ids, the comparison worked, the moveNode wasn't executed anymore and the duration fell to ~10 Seconds.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #55768: Drag & drop in Workspaces moves live pageClosedThorsten Kahler2014-02-07

Actions
Actions

Also available in: Atom PDF