Bug #40409
closed
typo3temp/compressor is flooded with identical files
100%
Description
If absRefPrefix is set the result of inlineStyle2TempFile is returned with absRefPrefix prepended. If this is a fully qualified URL t3lib_Compressor::createMergedFile() will download the contents to a temporary file on each page. Even though the contents and the filename of this temporary file stay the same the modified timestamp is altered and thus a new merged file is created in typo3temp/compressor/.
In one installation we found 26 GB of identical CSS files.
Possible solutions:- detect if 'external' file is in fact local file and handle it as local
- exclude 'external' files from merge/compress
- option to exclude inlineStyle2TempFile result from merging/compressing (would mean new feature)
Files
Updated by Ivan Dharma Kartolo about 12 years ago
can't reproduce this :(
Update: my bad :( it's reproduceable
Following are set in TS:- config.compressCSS
- config.concatenateCss
- config.minifyCSS
- config.absRefPrefix
Updated by Ivan Dharma Kartolo about 12 years ago
- File 40409-46.patch 40409-46.patch added
- Assignee set to Jigal van Hemert
the problem is, that the temporary file (external-xxxx) is always rewritten, even tough the file is not changed. therefore the md5 in createMergedFile function is always changed, since the timestamp of the temporary file is always new.
patch is made against 4.6.12.
the idea is to check if the temporary file exists and the content is the same with the content fetched.
if the file doesn't exist or the content not the same (with the saved one), then write the new file.
can you test is?
Updated by Ivan Dharma Kartolo about 12 years ago
- File 40409-46.patch 40409-46.patch added
new patch file
Updated by Gerrit Code Review about 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14268
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14269
Updated by Gerrit Code Review about 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14269
Updated by Gerrit Code Review about 12 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14269
Updated by Gerrit Code Review about 12 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14269
Updated by Gerrit Code Review about 12 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14269
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15442
Updated by Ivan Dharma Kartolo about 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset e4f6b2544125d7f6c3a9e192bc274acdfbbfb19e.
Updated by Gerrit Code Review about 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/15492
Updated by Xavier Perseguers about 12 years ago
Seems that it should not go to 4.5
Updated by Xavier Perseguers about 12 years ago
- Status changed from Under Review to Resolved
Updated by Gerrit Code Review almost 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/17643
Updated by Benni Mack over 11 years ago
- Status changed from Under Review to Resolved
won't fix in 4.5. so this is resolved.