Bug #40409
closed
typo3temp/compressor is flooded with identical files
Added by Jigal van Hemert about 12 years ago.
Updated about 6 years ago.
Description
If absRefPrefix is set the result of inlineStyle2TempFile is returned with absRefPrefix prepended. If this is a fully qualified URL t3lib_Compressor::createMergedFile() will download the contents to a temporary file on each page. Even though the contents and the filename of this temporary file stay the same the modified timestamp is altered and thus a new merged file is created in typo3temp/compressor/.
In one installation we found 26 GB of identical CSS files.
Possible solutions:
- detect if 'external' file is in fact local file and handle it as local
- exclude 'external' files from merge/compress
- option to exclude inlineStyle2TempFile result from merging/compressing (would mean new feature)
Files
can't reproduce this :(
Update: my bad :( it's reproduceable
Following are set in TS:
- config.compressCSS
- config.concatenateCss
- config.minifyCSS
- config.absRefPrefix
the problem is, that the temporary file (external-xxxx) is always rewritten, even tough the file is not changed. therefore the md5 in createMergedFile function is always changed, since the timestamp of the temporary file is always new.
patch is made against 4.6.12.
the idea is to check if the temporary file exists and the content is the same with the content fetched.
if the file doesn't exist or the content not the same (with the saved one), then write the new file.
can you test is?
- Status changed from New to Under Review
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Under Review
Seems that it should not go to 4.5
- Status changed from Under Review to Resolved
- Status changed from Resolved to Under Review
- Status changed from Under Review to Resolved
won't fix in 4.5. so this is resolved.
- Status changed from Resolved to Closed
Also available in: Atom
PDF