Task #41151: Improve error message for failling database creation - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #41151

closed

Improve error message for failling database creation

Added by Nicole Cordes over 11 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

6.0.0-RC1

Start date:

2012-09-21

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.0

PHP Version:

Tags:

Complexity:

no-brainer

Sprint Focus:

Description

Due to compatibility (maybe?) the create database command can't use quotes for new database names. Therefore (at least for MySQL databases) the characters to use is limited to 0-9, a-z, A-Z, $, _

This should be mentioned when creating the database fails.

Actions

Copy link

Updated by Markus Klein over 11 years ago

Hi!

Did you enter a database name with quotes? Or does TYPO3 quote somewhere where it is not appropriate?

Actions

Copy link

Updated by Nicole Cordes over 11 years ago

I tried to create a database typo3_6-0_blank. Self quoting is not allowed as the database name is parsed by preg_match('/[^[:alnum:]_-]/', $newDatabaseName)

The problem is the "-" which is not allowed in unquoted database names (see http://dev.mysql.com/doc/refman/5.1/en/identifiers.html)

Actions

Copy link

Updated by Gerrit Code Review over 11 years ago

Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14812

Actions

Copy link

Updated by Markus Klein over 11 years ago

Why no just quoting the database name in general?

Actions

Copy link

Updated by Nicole Cordes over 11 years ago

This was discussed by some guys yesterday evening and we were not sure if other databases allow those `` quotes. So the safest way to support all database system was to stay unquoted.

Actions

Copy link