Bug #41728: / in sword_list results in "Unknown modifier" error - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #41728

closed

/ in sword_list results in "Unknown modifier" error

Added by mpk about 12 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Indexed Search

Target version:

Start date:

2012-10-08

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

When you use the search plugin to find something with / (slash) in it, it results in the following error:

Core: Error handler (FE): PHP Warning: preg_split() [<a href='function.preg-split'>function.preg-split</a>]: Unknown modifier 'M' in .../typo3/sysext/cms/tslib/class.tslib_content.php line 4571

This can be solved when replacing / with \/ within $GLOBALS['TSFE']->sWordRegEx. This should happen at creation in typo3\sysext\cms\tslib\class.tslib_pagegen.php (around line 160+ in core 4.5.19).

Files

pagegen.diff (892 Bytes) pagegen.diff

mpk , 2012-10-15 22:56

Actions

Copy link

Updated by Steffen Gebert about 12 years ago

Category set to Indexed Search

Ouch, that's. of course, bad :-(

You're talking of indexed serach, I think?

You've already got the part of a patch. Could you push it to the review system and into the review workflow, please? See http://wiki.typo3.org/Contribution_Walkthrough_Tutorials and just ask here or in the mailing lists, if you have any questions.

Yours
Steffen

Actions

Copy link

Updated by mpk about 12 years ago

I am not using indexed search. But as it is about the sword array it is probably a problem there as well.

Pushing the patch seems to be difficult. I am stuck at
curl -o .git/hooks/commit-msg "http://wiki.typo3.org/wiki/images/5/5c/Commit-msg.txt" && chmod +x .git/hooks/commit-msg
(is it the same for windows?) It is answering:
".git/hooks/commits-msg: No such file or
Warning: directory
...
curl: (23) Failed writing body (0!=3471)"
:(

Actions

Copy link

Updated by mpk about 12 years ago

File pagegen.diff pagegen.diff added

I could only find a newer version (not 4.5).
But it looks like there is the same problem.

Attached is the best patch I could do.

Actions

Copy link

Updated by Mathias Schreiber almost 10 years ago

Status changed from New to Rejected
Is Regression set to No

has been removed from the core

Actions

Copy link

Updated by Alexander Stehlik over 9 years ago

It seems quite present to me in the current master

Please open this one again. Even if it was removed it should be fixed for 6.2 IMO.

Any reason why we do not use preg_quote() for escaping?

Actions

Copy link

Updated by Wouter Wolters over 9 years ago

Status changed from Rejected to New
TYPO3 Version changed from 4.5 to 6.2

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37328

Actions

Copy link

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37366

Actions

Copy link