TYPO3 Core

This patch seems the bug:

diff --git a/typo3/sysext/lang/lang.php b/typo3/sysext/lang/lang.php
index fa24065..f761244 100755
--- a/typo3/sysext/lang/lang.php
+++ b/typo3/sysext/lang/lang.php
@@ -536,7 +536,7 @@ class language {
      */
     protected function readLLfile($fileRef) {
         if ($this->lang !== 'default') {
-            $languages = array_reverse($this->languageDependencies);
+            $languages = $this->languageDependencies;
         } else {
             $languages = array('default');
         }

Have to test it in multiple conditions (including Frontend rendering) because I suspect side-effects.

How to reproduce¶

• Install an extension that only provide ll-XML translation files and provides a Backend module, e.g., TemplaVoilà
• Be sure to download translation for German
• Add this to your localconf.php:

$TYPO3_CONF_VARS['SYS']['localization']['locales']['user']['de_AT'] = 'Austrian German';

• Change your Backend language to Austrian German

=> You see module "Web > Page" instead of "Web > Seite" (Fallback to German expected)

• To further test the patch (from Gerrit), you may install an extension that does not provide a German translation either, e.g., "typo3mind" which provides a Backend module but only English as language. Expected is thus to get the English text (and not an empty label).

Problem is in fact that t3lib_div::readLLfile() populates 'target' with English (= 'source') if reading a non-XLIFF file (that is a ll-XML). When reading an XLIFF file and no translation exists, an empty array is returned instead of a fall back to English and the fall back is then properly performed outside of the readLLfile() method.

As such the suggested first-attempt patch is wrong, reversing the order of language dependencies is correct and the bug is in ll-XML handling.

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15634

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/15709

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15710