Project

General

Profile

Actions

Bug #42029

closed

Rootline relation overlay does not work for translated pages

Added by Andreas Wolf over 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Backend API
Target version:
Start date:
2012-10-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
hard
Is Regression:
Sprint Focus:

Description

Overlays for the relation fields of a page in the rootline, introduced with the rootline class refactoring, do not work for translated pages. The problem is that the overlay of data is done too early: RootlineUtility::enrichWithRelationFields() already kicks in long before the sys_language_uid is determined (which happens in index_ts.php:187, while determineId() - which needs the rootline - is called in line 145).

A possible solution would be to have the relation field enrichment done at a later point; that might however break other things.

Additionally, the language overlay done in RootlineUtility::enrichWithRelationFields() is also pointless, as the language is not known at that point.

One point where this becomes visible is when trying to access the media field of a translated page in the rootline with the "levelmedia" data key of stdWrap.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #39352: Refactor t3lib_pageSelect::getRootlineClosedSteffen Ritter2012-07-28

Actions
Related to TYPO3 Core - Bug #40609: Enable Frontend to deal with translated sys_file_referencesClosedSteffen Ritter2012-09-04

Actions
Actions #1

Updated by Lorenz Ulrich over 11 years ago

This problem also seems to become visible in conjunction with RealURL and therefore is a blocker for the final release IMO: Page paths of translated page are in the default language. See related issue #42880.

Actions #2

Updated by Andreas Wolf over 11 years ago

  • Priority changed from Should have to Must have
  • Target version changed from 6.0.0-RC1 to 6.0.0
  • Complexity changed from medium to hard
Actions #3

Updated by Andreas Wolf over 11 years ago

  • Assignee set to Andreas Wolf

I'm working on this, the patch is already there, but I need to fine-tune it.

Actions #4

Updated by Gerrit Code Review over 11 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16540

Actions #5

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16540

Actions #6

Updated by Gerrit Code Review over 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16540

Actions #7

Updated by Steffen Ritter over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Markus Timtner over 11 years ago

I can't confirm that this issue is resolved in combination with realurl -
I have two instances of fresh v6.0 instances here with multilanguage setup (DE/EN) and realurl 1.12.3,
realurl still doesn't show the localized pagepath.

Access available upon request.

Actions #9

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF