Project

General

Profile

Actions

Feature #42321

closed

MailUtility should be marked as deprecated

Added by Michael Bakonyi over 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Category:
Code Cleanup
Target version:
Start date:
2012-10-23
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:

Description

typo3/sysext/core/Classes/Utility/MailUtility.php should be marked as deprecated, as this is an old API which.

Internally it currently calls the SwiftMailer API (until 4.6 configurable via $TYPO3_CONF_VARS['MAIL']['substituteOldMailAPI'], from 4.7 done by default through a registered hook), but this is very error prone and not bullet-proof.

See the following discussions for past thoughts on that issue:

http://lists.typo3.org/pipermail/typo3-team-core/2012-May/051626.html

http://lists.typo3.org/pipermail/typo3-team-core/2012-January/051084.html


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #47037: Deprecate old mail functions and remove their usageClosedJigal van Hemert2013-04-08

Actions
Actions #1

Updated by Benni Mack over 11 years ago

  • Status changed from New to Accepted
  • Complexity set to medium

Definitively ToDo

Actions #2

Updated by Ernesto Baschny over 11 years ago

From the second thread, I quote myself:

So +1 on deprecating t3lib_utility_mail::mail(). Other methods like getSystemFrom, getSystemFromName, getSystemFromAddress are still interesting and can be kept in this utility class.

So let's deprecate it now (with 6.0) in this is the issue to do it.

Other thoughts for the future (could / should be a separate issue):

Another idea would be to add a very simple "simpleMail()" method there which can be used to simply send "simple mails out" (like notifications):

  • ASCII-text body
  • Subject
  • Array of destination addresses
  • From is chosen by the system

So that extensions wanting to just "say something via email" can do it with one simple line of code. Any further requirements (HTML-body, etc) the extension developer should create a t3lib_mail object.

Actions #3

Updated by Gerrit Code Review over 11 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16138

Actions #4

Updated by Ernesto Baschny over 11 years ago

  • Subject changed from MailUtility should use SwiftMailer or be marked as deprecated to MailUtility should be marked as deprecated
Actions #5

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/16138

Actions #6

Updated by Gerrit Code Review about 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/16138

Actions #7

Updated by Jigal van Hemert about 11 years ago

  • Category set to Code Cleanup
  • Assignee set to Jigal van Hemert
  • Target version set to 6.1.0-beta2
Actions #8

Updated by Gerrit Code Review about 11 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/16138

Actions #9

Updated by Gerrit Code Review about 11 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/16138

Actions #10

Updated by Gerrit Code Review about 11 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/16138

Actions #11

Updated by Gerrit Code Review about 11 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/16138

Actions #12

Updated by Stefan Neufeind about 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF