Bug #43874
closedarray_merge_recursive_overrule: __UNSET can't unset array values
100%
Description
If the $enableUnsetFeature parameter is true, array_merge_recursive_overrule you can unset values from the first array.
The phpDoc says:
* @param boolean $enableUnsetFeature If set, special values "__UNSET" can be used in the second array in order to unset array keys in the resulting array.
But in fact keys are only unset if they don't hold an array value. I see no reason why this should be like this. There should be the possibility to unset array values.
Updated by Markus Klein almost 12 years ago
Although this feature is not used in the Core at all, we can't change that behavior easily since this is public API.
Hence this would require a deprecation period of at least two versions first.
Updated by Sebastian Michaelsen almost 12 years ago
I don't agree. It just changes the feature in a way to behave like it was documented.
It's very unlikely that someone used __UNSET on an array value which he doesn't want to be unset. So I don't expect anything to break.
Updated by Tobias Liebig almost 12 years ago
- Category set to Backend API
- Complexity set to easy
Updated by Tobias Liebig almost 12 years ago
I also think this change won't break anything.
Updated by Sebastian Michaelsen almost 12 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset c0defbe74e3992b07dce859024d51544c4c7b9ed.
Updated by Gerrit Code Review almost 12 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/17529
Updated by Gerrit Code Review almost 12 years ago
Patch set 3 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/17529
Updated by Sebastian Michaelsen almost 12 years ago
- Status changed from Under Review to Resolved
Applied in changeset 2e3ad6942dc4b18471e377808e147098891f58c6.
Updated by Gerrit Code Review almost 12 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/17530
Updated by Sebastian Michaelsen almost 12 years ago
- Status changed from Under Review to Resolved
Applied in changeset 04f83a858f61921ce12a3a1948f557449d60f444.