Project

General

Profile

Actions

Bug #43959

closed

Overriding labels through TypoScript does not work

Added by Michael Stucki almost 12 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Category:
Localization
Target version:
Start date:
2012-12-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Overriding labels using TypoScript fails if the value is empty.
This was introduced during #39850, most likely by mistake.


Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #39850: pi_getLL() alternative language translation failsClosedXavier Perseguers2012-08-16

Actions
Related to TYPO3 Core - Bug #44099: L10n fallback does not work for TS labelsClosedXavier Perseguers2012-12-18

Actions
Has duplicate TYPO3 Core - Bug #45513: pi_getLL does not allow clearing labels via Typoscript any moreClosed2013-02-15

Actions
Actions #1

Updated by Gerrit Code Review almost 12 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/17149

Actions #2

Updated by Gerrit Code Review almost 12 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at https://review.typo3.org/17150

Actions #3

Updated by Gerrit Code Review almost 12 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17151

Actions #4

Updated by Markus Klein over 11 years ago

Looking at the code, extbase is also affected.

Actions #5

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17151

Actions #6

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19619

Actions #7

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19619

Actions #8

Updated by Markus Klein over 11 years ago

This problem only arises for translations. In default language this works (more or less by fluke).

HOW TO TEST (the extbase patch):

  • TYPO3 Version 4.6 - 6.1
  • Define any non-default language.
  • Install an extbase based extension like tx_news.
  • Insert the plugin.
  • (Showing FE now, will give the message (e.g. de): Keine Artikel vorhanden.)
  • Clear the label in Typoscript: plugin.tx_news._LOCAL_LANG.de.list_nonewsfound =
  • Expected output should be empty, but you'll get a fallback to English instead, saying: No news available.
Actions #9

Updated by Gerrit Code Review over 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17151

Actions #10

Updated by Gerrit Code Review over 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19619

Actions #11

Updated by Gerrit Code Review over 11 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19619

Actions #12

Updated by Gerrit Code Review over 11 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19619

Actions #13

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch extbase_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/19934

Actions #14

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch extbase_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/19936

Actions #15

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch extbase_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/19936

Actions #16

Updated by Markus Klein over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:dd8cf61eaf653f5b2b25c4d3a8221d08dda8286d.

Actions #17

Updated by Michael Stucki over 11 years ago

  • Status changed from Resolved to Accepted
  • Target version changed from 6.0.1 to 6.0.5
  • % Done changed from 100 to 80

The problem is not solved!

https://review.typo3.org/#/c/19619/ (master)
https://review.typo3.org/#/c/19934/ (TYPO3_6-0)
https://review.typo3.org/#/c/19936/ (TYPO3_4-7)

The fixes above were only related to clearing labels in Extbase. They should not have contained "Fixes: ..." in the commit message.

The original issue remains and is still waiting for reviews:

https://review.typo3.org/#/c/17151/ (master)
https://review.typo3.org/#/c/17149/ (TYPO3_4-7)
(TYPO3_6-0 patch is yet missing)

Actions #18

Updated by Gerrit Code Review over 11 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/20354

Actions #19

Updated by Gerrit Code Review over 11 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17151

Actions #20

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/20495

Actions #21

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/20496

Actions #22

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/20354

Actions #23

Updated by Markus Klein over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 80 to 100
Actions #24

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF