Task #44152

Add save only button

Added by Christopher Seidel almost 7 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
scheduler
Target version:
Start date:
2012-12-20
Due date:
% Done:

100%

TYPO3 Version:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Hi,

in every element there is an option to save and save/close.

It would be great to have the save button aswell and not only the save/close button, because when you need to change parameters you will have to reopen always the task after creating it and this costs time.

Thanks


Related issues

Blocks TYPO3 Core - Bug #48022: Fatal error: Call to a member function getNotificationEmail() on a non-object when saving task Closed 2013-05-07

Associated revisions

Revision 357ce730 (diff)
Added by Lorenz Ulrich almost 7 years ago

[TASK] Add save only button to Scheduler task

Scheduler tasks currently miss a save only button. Since Firefox and
Opera don't send the value of an <input type="submit">, the save and
save & close buttons are wrapped in a <button type="submit"> to ensure
saving and saving & closing is cross-browser compatible.

Change-Id: Ia5e32efc2e5e2af2943374c9a570a3a94b0511b4
Fixes: #44152
Releases: 6.1, 6.0, 4.7
Reviewed-on: https://review.typo3.org/17590
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Ingo Renner
Tested-by: Ingo Renner
Reviewed-by: Christopher Seidel
Tested-by: Christopher Seidel
Reviewed-by: Francois Suter
Tested-by: Francois Suter

Revision 5fd986c7 (diff)
Added by Lorenz Ulrich almost 7 years ago

[TASK] Add save only button to Scheduler task

Scheduler tasks currently miss a save only button. Since Firefox and
Opera don't send the value of an <input type="submit">, the save and
save & close buttons are wrapped in a <button type="submit"> to ensure
saving and saving & closing is cross-browser compatible.

Change-Id: Ia5e32efc2e5e2af2943374c9a570a3a94b0511b4
Fixes: #44152
Releases: 6.1, 6.0, 4.7
Reviewed-on: https://review.typo3.org/17681
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision 05d35ee3 (diff)
Added by Lorenz Ulrich almost 7 years ago

[TASK] Add save only button to Scheduler task

Scheduler tasks currently miss a save only button. Since Firefox and
Opera don't send the value of an <input type="submit">, the save and
save & close buttons are wrapped in a <button type="submit"> to ensure
saving and saving & closing is cross-browser compatible.

Change-Id: Ia5e32efc2e5e2af2943374c9a570a3a94b0511b4
Fixes: #44152
Releases: 6.1, 6.0, 4.7
Reviewed-on: https://review.typo3.org/17682
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Revision f3f892ee (diff)
Added by Thorsten Kahler over 6 years ago

[BUGFIX] Saving a scheduler task throws fatal error

The backport of 357ce730 for version 4.7 was applied to the
"update" code instead of the "save" code. This patch moves the change to
the right place.

Change-Id: I8917a4161b5221eaf3041bad78713813ff18a0d3
Fixes: #48022
Related: #44152
Follow-up to: 05d35ee3cff633c82e440a452b6a08690cdc4092
Releases: 4.7
Reviewed-on: https://review.typo3.org/20638
Reviewed-by: Stephan Großberndt
Tested-by: Stephan Großberndt
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1 Updated by Jigal van Hemert almost 7 years ago

Can you provide a patch for it? More information about contributing can be found at http://wiki.typo3.org/Contribution_Walkthrough_Tutorials

#2 Updated by Oliver Hader almost 7 years ago

  • Target version set to 4.7.8

Valid for TYPO3 4.7 and any later version - before that, the buttons have been arranged at the bottom the the edit form.

#3 Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17590

#4 Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17590

#5 Updated by Gerrit Code Review almost 7 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17590

#6 Updated by Gerrit Code Review almost 7 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17590

#7 Updated by Gerrit Code Review almost 7 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17590

#8 Updated by Lorenz Ulrich almost 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Gerrit Code Review almost 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/17681

#10 Updated by Gerrit Code Review almost 7 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/17682

#11 Updated by Lorenz Ulrich almost 7 years ago

  • Status changed from Under Review to Resolved

#12 Updated by Michael Stucki almost 6 years ago

  • Category set to scheduler

#13 Updated by Michael Stucki almost 6 years ago

  • Project changed from Scheduler to TYPO3 Core
  • Category changed from scheduler to scheduler

#14 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF