Task #44972

Update documentation: Mark borderCol and rowSpace options from IMGTEXT as removed

Added by Sebastian Michaelsen over 8 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Documentation
Start date:
2013-01-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Passing borderCol and rowSpace to IMGTEXT doesn't have any effect anymore.

However the correspoding constants {$styles.content.imgtext.borderColor}
and {$styles.content.imgtext.rowSpace} are used in CSC's default CSS.

#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17844

#2

Updated by Chris topher over 8 years ago

  • Status changed from Under Review to On Hold
  • Target version changed from 6.0 to 6.1
#3

Updated by Chris topher about 8 years ago

  • Project changed from 1112 to TYPO3 Core
  • Status changed from On Hold to New
  • Target version deleted (6.1)
#4

Updated by Chris topher about 8 years ago

  • Subject changed from Remove borderCol and rowSpace options from IMGTEXT to Update documentation: Mark borderCol and rowSpace options from IMGTEXT as removed
  • TYPO3 Version set to 6.1

TSref is not the right manual to be changed:

Please modify the manual of CSS styled content (typo3\sysext\css_styled_content\Documentation):
Remove these properties there.

#5

Updated by Mathias Schreiber over 6 years ago

  • Category set to Documentation
  • Target version set to 7 LTS
#6

Updated by Wouter Wolters almost 6 years ago

There is still code in the class

sysext/compatibility6/Classes/ContentObject/ImageTextContentObject.php
91: $borderColor = isset($conf['borderCol.']) ? $this->cObj->stdWrap($conf['borderCol'], $conf['borderCol.']) : $conf['borderCol'];
92: if (!$borderColor) {
93: $borderColor = 'black';
382: $imageHTML = '<table border="0" cellpadding="' . $borderThickness . '" cellspacing="0" bgcolor="' . $borderColor . '"' . $Talign . '><tr><td>' . $imageHTML . '</td></tr></table>';

#7

Updated by Chris topher almost 6 years ago

Wouter, that is correct: The properties both are used in ImageTextContentObject.php.

But they are no longer used in CSS styled content. For CSS styled content these properties are removed. And that is what should still be documented - the properties should be removed from typo3\sysext\css_styled_content\Documentation!

#8

Updated by Riccardo De Contardi over 5 years ago

  • Target version changed from 7 LTS to Candidate for patchlevel
#9

Updated by Riccardo De Contardi about 4 years ago

If I am not wrong, $styles.content.imgtext.rowSpace is still used by Css Styled Content, version8.7-dev (latest master)

see:

typo3/sysext/css_styled_content/Configuration/TypoScript/Styling/setup.txt
typo3/sysext/css_styled_content/Configuration/TypoScript/constants.txt

On the same files, I have not seen borderCol, but there are two constants:

$styles.content.imgtext.borderColor

$styles.content.imgtext.borderColor2

and only the first one seem used.

#10

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54462

#11

Updated by Anonymous over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#12

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF