Feature #45725

FAL file collections should be able to be recursive

Added by Maarten Mandemaker over 6 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2013-02-21
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

FAL file folders should contain an option to be recursive.

page.10 = FILES
page.10 {
folders = 1:images/
folders.recursive = 1
}

typo3_src-6.2.4.diff View (3.52 KB) Stephan Bauer, 2014-07-16 19:17


Related issues

Duplicates TYPO3 Core - Feature #61238: File collection: to show also folders recursive with files Closed 2014-08-28
Duplicated by TYPO3 Core - Feature #67727: CE file links folder recursively Closed 2015-06-24

Associated revisions

Revision 505da82c (diff)
Added by Frans Saris over 4 years ago

[FEATURE] Add recursive option to FolderBasedFileCollection

Adds a new option for FolderBasedFileCollection to fetch files
recursive from selected folder.

Resolves: #45725
Releases: master
Change-Id: I2761568b488599e53594d4f9a14cfcc5842e83e7
Reviewed-on: http://review.typo3.org/32638
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Alexander Opitz <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

History

#1 Updated by Wouter Wolters about 6 years ago

  • TYPO3 Version changed from 6.0 to 6.2

#2 Updated by Wolfgang Wagner over 5 years ago

Yes, that would be a very nice feature!

#3 Updated by Uwe Wiebach over 5 years ago

It would be great if this could not only be done for folder based collections but for category based ones too. Maybe it could be the default behaviour for these so you don't need to set the parent category and the child for the file. Or is there a way to select the parent if the child is selected?

#4 Updated by Stephan Bauer over 5 years ago

With the patch attached it is possible to get files recursive (only in CE, no typoscript)

#5 Updated by Frans Saris over 5 years ago

Hi Stephan,

tnx for the patch. Had a quick look at it. But it misses some stuff.

  • $this->recursive isn't declared in FolderBasedFileCollection.php
  • recursive needs to be added to the sysext/core/ext_tables.sql
  • You are using a non existing constant as filter option

Could you maybe update your patch and push it to gerrit? (see http://wiki.typo3.org/Contribution_Walkthrough_Tutorials)

gr. Frans

#6 Updated by Gerrit Code Review about 5 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#7 Updated by Alexander Opitz about 5 years ago

  • Category set to File Abstraction Layer (FAL)

Hi Stephan,

can you please rework your patch and fix the issues which Frans mentioned?

#8 Updated by Stephan Bauer about 5 years ago

Hello Alexander,

I think the patch from Frans complete or am I wrong?

#9 Updated by Alexander Opitz about 5 years ago

Hi Stephan,

Frans only took your patch and postet it to gerrit and asked you to update your patch:

* $this->recursive isn't declared in FolderBasedFileCollection.php
* recursive needs to be added to the sysext/core/ext_tables.sql
* You are using a non existing constant as filter option

#10 Updated by Frans Saris about 5 years ago

I updated the missing parts already. But for this issue the typoscript rendering possibilities of file collections should also be changed.

#11 Updated by Gerrit Code Review almost 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#12 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#13 Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#14 Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#15 Updated by Daniel Goerz over 4 years ago

I've added a patchset that enables the functionality of recursive folders in TypoScript FILES object. You can test it e.g. with this TS snippet:

page = PAGE
page.10 = FILES
page.10 {
  folders = 1:images/
  folders.recursive = 1

  renderObj = IMAGE
  renderObj {
    file.import.data = file:current:uid
  }
}

Of course you need to have a folder "images" in your fileadmin that contains at least one subfolder.

#16 Updated by Gerrit Code Review over 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#17 Updated by Gerrit Code Review over 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#18 Updated by Gerrit Code Review over 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#19 Updated by Gerrit Code Review over 4 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#20 Updated by Gerrit Code Review over 4 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#21 Updated by Gerrit Code Review over 4 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#22 Updated by Gerrit Code Review over 4 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#23 Updated by Gerrit Code Review over 4 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32638

#24 Updated by Frans Saris over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#25 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF