Project

General

Profile

Actions

Feature #45883

closed

Adding getPageOverlay_postProcess hook

Added by Armin Vieweg about 11 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2013-02-27
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Hi,

I need to modify attributes of page records. The best point for this is the getPageOverlay() method in t3lib_pageSelect. It has already a preProcess hook, where I could modify eg. the title of the page. But after this hook some translations are performed and merged with my modified array, which will overwrite my changes with the translated attributes.

So, the preProcess hook works fine with page records in default language. But when I want to modify also translated pages, I have to write a xclass, because no postProcess is existing here.

Furthermore the getRecordOverlay() method has a pre and postProcess hook, so it seems to be a bit inconsistent.

I wish there would be such postProcess hook in getPageOverlay() method, too.
Thanks!


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Epic #88027: Properly handle Hooks/Signals and EventsClosedBenni Mack2022-04-22

Actions
Actions #1

Updated by Gerrit Code Review about 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18515

Actions #2

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18515

Actions #3

Updated by Mathias Schreiber over 9 years ago

Hey Armin,

would you continue to work on this or abandon the patch?

Thanks in advance

Actions #4

Updated by Alexander Opitz over 8 years ago

Patch was from Georg.

@Georg Ringer
would you continue to work on this or abandon the patch?

Actions #5

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/18515

Actions #6

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/18515

Actions #7

Updated by Georg Ringer over 7 years ago

  • Status changed from Under Review to Rejected

abandoned

Actions #8

Updated by Georg Ringer over 7 years ago

  • Status changed from Rejected to New
Actions #9

Updated by Benni Mack about 5 years ago

  • Related to Epic #88027: Properly handle Hooks/Signals and Events added
Actions #10

Updated by Susanne Moog about 4 years ago

  • Status changed from New to Closed

As this is a technical task and has not gotten priority for a long long time (in between the class names, locations and even the hook system changed) I'm going to close this issue now. If an event in that location is still needed (and there is no other mechanism that can be used in the meantime) please reopen the ticket once work starts again.

Actions #11

Updated by Peter Schuhmann almost 2 years ago

hello everyone. was just working on something similar: I want to manual set specific values from the original page to the overlay since the overlay does not have the value. Like "use default language" except the field is background field. I totally agree that the behavior is inconsistent here since there is a getPageOverlay_preProcess hook but no getPageOverlay_postProcess which would be the right behavior and would propably take like 5 Minutes to implement. I would love to see that implemented.

Actions

Also available in: Atom PDF