TYPO3 Core

This is the PHP code:
isReadOnlyFolder($folder) { return $GLOBALS['FILEMOUNTS'][$this->fileProcessor->checkPathAgainstMounts(rtrim($folder, '/') . '/')]['type'] == 'readonly';

Here $folder is a folder object from TYPO3\CMS\Core\Resource\Folder. But instead, it should be a string with an absolute filepath.

Backtrace:

#0 TYPO3\CMS\Recordlist\Browser\ElementBrowser->isReadOnlyFolder(TYPO3\CMS\Core\Resource\Folder Object (
  [] => TYPO3\CMS\Core\Resource\ResourceStorage Object (
    [] => TYPO3\CMS\Core\Resource\Driver\LocalDriver Object (
      [] => /var/www/fileadmin/,
      [] => Array ([0] => sha1,
      [1] => md5),
      [] => fileadmin/,
      [] => ,
      [] => TYPO3\CMS\Core\Resource\ResourceStorage Object (
        *RECURSION*,
        [] => ,
        [] => TYPO3\CMS\Core\Resource\Folder Object (
          *RECURSION*,
          [] => Array (
            [basePath] => fileadmin/,
            [pathType] => relative
          ),
          [] => getFileList_itemCallback,
          [] => getFolderList_itemCallback,
          [] => 7
        ),
        [] => Array (
          [uid] => 1,
          [pid] => 0,
          [tstamp] => 1371345593,
          [crdate] => 1371345593,
          [cruser_id] => 0,
          [deleted] => 0,
          [hidden] => 0,
          [name] => fileadmin/,
          [description] => Das lokale fileadmin/ Verzeichnis.,
          [driver] => Local,
          [configuration] => fileadmin/ relative ,
          [is_browsable] =>
        ..........
#1 TYPO3\CMS\Recordlist\Browser\ElementBrowser->main_file() called at [~/typo3_src-6.0.6/typo3/sysext/recordlist/Classes/Controller/ElementBrowserController.php:145]
#2 TYPO3\CMS\Recordlist\Controller\ElementBrowserController->main() called at [~/typo3_src-6.0.6/typo3/browse_links.php:49]

So it is in fact TYPO3\CMS\Recordlist\Browser\ElementBrowser::main_file(), which gives the wrong argument to isReadOnlyFolder().

The problem is line 1138, where the code even says that $fileOrFolderObject, an object, will be put into the variable:

At the end we need to replace the usage of the (deprecated) BasicFileUtility (which is $this->fileProcessor in ElementBrowser) by the new BE_USERS->getFileStorages() and then call isWithinFileMountBoundaries instead of the old-school methods of BasicFileUtility.

This will not only solve this bug, but fix a deprecation policy violation, that we currently have, where we init BasicFileUtility which is deprecated since 6.0.

$GLOBALS['FILEMOUNTS'] is always empty now.

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25358

Applied in changeset e8a2b21e913e4c309f80ca809b23876c79adad49.

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26467

Applied in changeset e8978f9d8c70febb6fb8ec0f6181f533f2523ccf.