Feature #49060

Compare database should reflect mysql column comments

Added by Nico de Haen about 8 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2013-06-12
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Mysql column comments in ext_tables.sql are added to the database but the Install tool complains that the table definitions differ from the database. The reason is, that the COMMENT statements are not included in the SHOW COLUMN statement in the DatabaseConnection->admin_get_fields method. The attached patch changes this and adds the comment in the SchemaMigrator->assembleFieldDefinition method.


Files

mysql_comments.patch (1.12 KB) mysql_comments.patch Nico de Haen, 2013-06-12 14:27
49060_step1_initial_status.png (65.9 KB) 49060_step1_initial_status.png Mathias Schreiber, 2015-01-18 19:09
49060_step2_add_comment.png (65.3 KB) 49060_step2_add_comment.png Mathias Schreiber, 2015-01-18 19:09
49060_step3_remove_existing_comment.png (63.9 KB) 49060_step3_remove_existing_comment.png Mathias Schreiber, 2015-01-18 19:09
#1

Updated by Markus Klein about 8 years ago

  • Target version deleted (6.2.0)

Hi Nico!

Thanks for your contribution.
Would you mind pushing your patch to our review system?
You can find all necessary information here: http://wiki.typo3.org/Contribution_Walkthrough_Tutorials

Feel free to contact me if you have questions.

~Markus

#2

Updated by Nico de Haen about 8 years ago

Yes of course. No problem. I will push it to the review system as soon as I have time

#3

Updated by Gerrit Code Review about 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21478

#4

Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21478

#5

Updated by Gerrit Code Review about 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21478

#6

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/21478

#7

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/21478

#9

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/21478

#10

Updated by Nico de Haen over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#11

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF