Compare database should reflect mysql column comments
Mysql column comments in ext_tables.sql are added to the database but the Install tool complains that the table definitions differ from the database. The reason is, that the COMMENT statements are not included in the SHOW COLUMN statement in the DatabaseConnection->admin_get_fields method. The attached patch changes this and adds the comment in the SchemaMigrator->assembleFieldDefinition method.
[FEATURE] Reflect mysql comments in SchemaMigrator
This enables that the database migration and
comparison process includes mysql column comments.
Reviewed-by: Anja Leichsenring <email@example.com>
Tested-by: Anja Leichsenring <firstname.lastname@example.org>
Reviewed-by: Oliver Klee <email@example.com>
Reviewed-by: Alexander Opitz <firstname.lastname@example.org>
Tested-by: Alexander Opitz <email@example.com>
#1 Updated by Markus Klein almost 7 years ago
- Target version deleted (
Thanks for your contribution.
Would you mind pushing your patch to our review system?
You can find all necessary information here: http://wiki.typo3.org/Contribution_Walkthrough_Tutorials
Feel free to contact me if you have questions.