Feature #49060

Compare database should reflect mysql column comments

Added by Nico de Haen almost 7 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2013-06-12
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Mysql column comments in ext_tables.sql are added to the database but the Install tool complains that the table definitions differ from the database. The reason is, that the COMMENT statements are not included in the SHOW COLUMN statement in the DatabaseConnection->admin_get_fields method. The attached patch changes this and adds the comment in the SchemaMigrator->assembleFieldDefinition method.

mysql_comments.patch View (1.12 KB) Nico de Haen, 2013-06-12 14:27

49060_step1_initial_status.png View (65.9 KB) Mathias Schreiber, 2015-01-18 19:09

49060_step2_add_comment.png View (65.3 KB) Mathias Schreiber, 2015-01-18 19:09

49060_step3_remove_existing_comment.png View (63.9 KB) Mathias Schreiber, 2015-01-18 19:09

Associated revisions

Revision bcbcd4c6 (diff)
Added by Nico de Haen about 5 years ago

[FEATURE] Reflect mysql comments in SchemaMigrator

This enables that the database migration and
comparison process includes mysql column comments.

Resolves: #49060
Releases: master

Change-Id: I8785690496bbc4fa80a8bf98ca75029c48f500f9
Reviewed-on: http://review.typo3.org/21478
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Alexander Opitz <>
Tested-by: Alexander Opitz <>

History

#1 Updated by Markus Klein almost 7 years ago

  • Target version deleted (6.2.0)

Hi Nico!

Thanks for your contribution.
Would you mind pushing your patch to our review system?
You can find all necessary information here: http://wiki.typo3.org/Contribution_Walkthrough_Tutorials

Feel free to contact me if you have questions.

~Markus

#2 Updated by Nico de Haen almost 7 years ago

Yes of course. No problem. I will push it to the review system as soon as I have time

#3 Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21478

#4 Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21478

#5 Updated by Gerrit Code Review almost 7 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21478

#6 Updated by Gerrit Code Review about 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/21478

#7 Updated by Gerrit Code Review about 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/21478

#8 Updated by Mathias Schreiber about 5 years ago

Added images to illustrate the new behavior

#9 Updated by Gerrit Code Review about 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/21478

#10 Updated by Nico de Haen about 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF