Project

General

Profile

Actions
Copy link

Feature #49060

closed

Compare database should reflect mysql column comments

Added by Nico de Haen almost 11 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2013-06-12
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Mysql column comments in ext_tables.sql are added to the database but the Install tool complains that the table definitions differ from the database. The reason is, that the COMMENT statements are not included in the SHOW COLUMN statement in the DatabaseConnection->admin_get_fields method. The attached patch changes this and adds the comment in the SchemaMigrator->assembleFieldDefinition method.

Files

Download all files
mysql_comments.patch (1.12 KB) mysql_comments.patch Nico de Haen, 2013-06-12 14:27
49060_step1_initial_status.png (65.9 KB) 49060_step1_initial_status.png Mathias Schreiber, 2015-01-18 19:09
49060_step2_add_comment.png (65.3 KB) 49060_step2_add_comment.png Mathias Schreiber, 2015-01-18 19:09
49060_step3_remove_existing_comment.png (63.9 KB) 49060_step3_remove_existing_comment.png Mathias Schreiber, 2015-01-18 19:09
Actions
Copy link

Also available in: Atom PDF