TYPO3 Core

Your solution seams a little hacky to me.
You change the default rendering of sectionIndex menus in css_styled_content, but this does not address sectionIndex menu built from scratch.

When I build a HMENU with sectionIndex, I expect that this menu renders consistently if the page where it is added is "in menu" or "not in menu". The sectionIndex menu is, for me, just an element of the page (like any other tt_content), and it should be rendered on the page regardless of the page status.

My proposal address the described behavior : the sectionIndex menu will be rendered on the page, regardless of the status of the page's property on which it is inserted, and without the need of a TypoScript hack.

If your solution is still accepted by the majority, then could you fix also the documentation of HMENU.sectionIndex, to point that "needed" TypoScript hack ?

Best regards
Rémy

Hey Daniel,

thx for your feedback. To me the whole section index php code seems hacky... building "virtual" page records from tt_content rows... not the best way IMO.

So I used the typoscript setting which is made for such a usecase.
But you are abolutely right, that this needs to be documented then.

I still think that the sectionIndex menu should be rendered on the page, regardless of the status of the page's "nav_hide" property on which it is inserted, and without the need of a TypoScript hack...

Alexander von Drach wrote:

I also have to deal with this problem, but I think the above patch is not the best solution, it's simply a hard-coded includeNotInMenu=1 for section index menues. Nor is https://review.typo3.org/24872, because wwhile you can still change the setting for menues, this won't allow you to have a section index menu on a page which is hidden in menues, and also hide some content elements from the section index.

A better solution would be to respect the sectionIndex flag in the content record,

So instead of
$result[$uid]['nav_hide'] = '0';
it should be
$result[$uid]['nav_hide'] = !$row['sectionIndex'];

Or even better, add AND sectionIndex=1 to the query fetching the content elements (and set nav_hide to 0), see the applied patch.

The nav_hide thing and hiding elements from section index are two separate things and the last works correct. Check for

$doIncludeInSectionIndex = $row['sectionIndex'] >= 1;

Adding this in Typoscript is no "hack". It uses a simple setting which is made for such a usecase.
Hardcoding this no one could simple change the behaviour. Using settings, that are already there is the best IMO. Hacking this virtual page records created from content records in addition is more a bad practice than using a simple setting.
But you are invited to push another changeset for this issue and if it will get enough votes, fine with it.

Alexander von Drach wrote:

Please ignore my above patch, it is incorrect since it assumes that tt_content.sectionIndex can't be overwritten in translated elements.

Ok

I think this whole issue needs some rework.

The first impression is, that this is more than a bugfix, that could go into the current version.

I don't get why pages and content elements are treated differently regarding the TS configuration (includeNotInMenu vs sectionIndex.type).

Because basically a HMENU renders pages. But here it is used (since 4.6) to render a menu of content elements. Till 4.5 a CONTENT object was used for the sectionIndex ( https://git.typo3.org/Packages/TYPO3.CMS.git/blob/master:/typo3/sysext/css_styled_content/static/v4.5/setup.txt#l1455 )
And the basic problem is, that the page properties are copied and overwritten with the content data. https://git.typo3.org/Packages/TYPO3.CMS.git/blob/master:/typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php#l1866

This is why you could have settings regarding the page (includeNotInMenu) and the content (sectionIndex.type) properties here.

Marc Bastian Heinrichs wrote:

The nav_hide thing and hiding elements from section index are two separate things and the last works correct. Check for
[...]
in the code.

Yes, indeed. I got that wrong yesterday.

Adding this in Typoscript is no "hack". It uses a simple setting which is made for such a usecase.

Here is disagree. Well, it's no hack - however, he setting is not simple, but quite confusing and not intuitive.
Also it is limiting your options (see my previous comment).

Hardcoding this no one could simple change the behaviour. Using settings, that are already there is the best IMO. Hacking this virtual page records created from content records in addition is more a bad practice than using a simple setting.

Hardcoding is bad indeed (and I also missed the point that there might be a section index spawning multiple pages, where some might be hidden in menues, so ignoring nav_hide of the page is also incorrect).

Using settings is the correct way, however, if existing settings are confusing and preventing possibilities, they should be changed.

My main point is that includeNotInMenu should refer to the entities actually displayed in the menu. This is imho more logical than always referring it to the page (especially when almost all section indexes will only contain elements from the same page that contains them, where it is obvious that all elements should be included).

The first impression is, that this is more than a bugfix, that could go into the current version.

Yes, it is more, and possible side effects (i.e. breaking the configuration of existing intallations) should be carefully considered before adding this to released versions. And your patch should indeed be sufficient for most cases (if not all existing, since the impossible cases are rather exotic).
But I would like to see it changed in coming versions.

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/24872

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/24872

Hi,

maybe I'm missing something, but wouldn't unsetting nav_hide function sectionIndex in the AbstractMenuContentObject work?

That method is only used to render sections. So the case(s) would be:

Page has set nav_hide, has sections which can be configured to be displayed by setting the sectionIndex checkbox.
Page has not set nav_hide, sections same as above.

In both cases I would expect a section menu to show all sections configured to be shown, independent from the page they are on. Unsetting $result[$uid]['nav_hide'] in said method should do that (as the skipping of records with sectionIndex disabled is done separately).

Is there another case to consider?

Thanks,

Susi

Susanne, this was exactly the purpose of my first patch :)

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/24872