Label user function for sys_file_reference uses HTML
The label user function for sys_file_reference uses HTML which results in strange data in the workspace module, the admin log and possibly also in other components that list sys_file_reference records in a list (see attached screenshots).
This behaviour has been introduced with this change:
[BUGFIX] Label user function for sys_file_reference uses HTML
The change I7770044c11a6c1a1bcb51a3bfc11b85923653196 added meta
information for the FAL IRRE headers.
It uses a definition list to show certain fields of the related record
inside the title (thus visible if collapsed).
The HTML markup leads to problems in other places of the backend, most
noteable in the workspace module.
Introduce a separate user function only for inline labels,
using the same signature as the normal label_userFunc.
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
#1 Updated by Markus Klein over 6 years ago
What do you propose to change here?
What do you want to see as label in the Workspace Module?
I'd say we change the InlineElement.php to add another option/parameter/whatever to the userfunc called, such that the userfunc can distinguish between normal labeling and inline labeling.
#5 Updated by Philipp Gampe over 6 years ago
- Assignee set to Philipp Gampe
I changed this to a new config option
inlineLabel_userFunc with the same signature as the
InlineElement::renderForeignRecordHeader is only called from
InlineElement::renderForeignRecord which in turn is only used to render IRRE fields AFAICT.
That way all other places preserve the behavior.