Bug #52285
closed
CategoryCollection must handle multiple category fields per table
100%
Description
Feature #51921 introduced the possibility to have multiple category selectors per table. The CategoryCollection class was not updated accordingly and - in the current state - will retrieve relations for all fields. The CategoryCollection must be modified to take the field name into account.
This also has an impact on the recently introduced category-based page menu, which needs to show a field selector on top of the category selector.
Updated by Gerrit Code Review over 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24066
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24066
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24066
Updated by Francois Suter over 10 years ago
To simplify testing, you can install extension "examples" (https://git.typo3.org/TYPO3CMS/Extensions/examples.git), which adds a second category selector to the "pages" table.
Updated by Francois Suter over 10 years ago
More detailed testing instructions:
- install extension "examples" (from https://git.typo3.org/TYPO3CMS/Extensions/examples.git)
- edit a few pages and assign them to different categories using both selectors
- create a category-based page menu, and choose any of the two selectors as reference field
- view it and observe that pages selection was based on relations created in both selectors
- apply the patch
- view the page menu again: it should contain only pages related to categories from the correct reference field
Updated by Gerrit Code Review over 10 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24066
Updated by Fabien Udriot over 10 years ago
- create a category-based page menu, and choose any of the two selectors as reference field
Just for making it more straightforward, patch https://review.typo3.org/#/c/23905/ must be applied beforehand.
Updated by Francois Suter over 10 years ago
Fabien Udriot wrote:
- create a category-based page menu, and choose any of the two selectors as reference field
Just for making it more straightforward, patch https://review.typo3.org/#/c/23905/ must be applied beforehand.
No, that's wrong! The category-based page menu already exists in the Core. The patch you point to introduces a tt_content menu. So no need to apply another patch to test this one.
Updated by Gerrit Code Review over 10 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24066
Updated by Francois Suter over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1598cd6491a112db98487277ccc3b813e182e44d.
Updated by Gerrit Code Review over 10 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24860
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24860
Updated by Marc Bastian Heinrichs over 10 years ago
- Status changed from Under Review to Resolved
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed