Bug #52285: CategoryCollection must handle multiple category fields per table - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Bug #52285

closed

CategoryCollection must handle multiple category fields per table

Added by Francois Suter about 11 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Francois Suter

Category:

Miscellaneous

Target version:

6.2.0

Start date:

2013-09-26

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.3

Tags:

Complexity:

medium

Is Regression:

Sprint Focus:

Description

Feature #51921 introduced the possibility to have multiple category selectors per table. The CategoryCollection class was not updated accordingly and - in the current state - will retrieve relations for all fields. The CategoryCollection must be modified to take the field name into account.

This also has an impact on the recently introduced category-based page menu, which needs to show a field selector on top of the category selector.

Related issues 3 (0 open — 3 closed)

Related to TYPO3 Core - Bug #51921: Only 1 category field per table possible

Closed

2013-09-11

Actions

Related to TYPO3 Core - Task #52836: Let itemsProcFunc throw Exceptions

Closed

Francois Suter

2013-10-15

Actions

Related to TYPO3 Core - Bug #52910: CategoryRegistryTest is broken

Closed

2013-10-17

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24066

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24066

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24066

Actions

Copy link

Updated by Francois Suter about 11 years ago

To simplify testing, you can install extension "examples" (https://git.typo3.org/TYPO3CMS/Extensions/examples.git), which adds a second category selector to the "pages" table.

Actions

Copy link

Updated by Francois Suter about 11 years ago

More detailed testing instructions:

install extension "examples" (from https://git.typo3.org/TYPO3CMS/Extensions/examples.git)
edit a few pages and assign them to different categories using both selectors
create a category-based page menu, and choose any of the two selectors as reference field
view it and observe that pages selection was based on relations created in both selectors
apply the patch
view the page menu again: it should contain only pages related to categories from the correct reference field

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24066

Actions

Copy link

Updated by Fabien Udriot about 11 years ago

create a category-based page menu, and choose any of the two selectors as reference field

Just for making it more straightforward, patch https://review.typo3.org/#/c/23905/ must be applied beforehand.

Actions

Copy link

Updated by Francois Suter about 11 years ago

Fabien Udriot wrote:

create a category-based page menu, and choose any of the two selectors as reference field

Just for making it more straightforward, patch https://review.typo3.org/#/c/23905/ must be applied beforehand.

No, that's wrong! The category-based page menu already exists in the Core. The patch you point to introduces a tt_content menu. So no need to apply another patch to test this one.

Actions

Copy link