Project

General

Profile

Actions

Bug #53928

closed

itemsProcFunc for Radio-Buttons doesn't work correctly

Added by Uwe Wiebach almost 11 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2013-11-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.4
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

As noone seems to answer this issue, I recreate it. And to quote myself: If a radio button is filled with itemsProcFunc, the value check (function checkValue_radio in DataHandler.php) fails as it only test the items-array ...

I've come up with kind of a solution (patch to current master attached): if the tca config has a itemsProcFunc and the selected value doesn't match one in the items-array, just accept it. I don't know whether this solution is sufficient for you, but at least it works.


Files

DataHandler.patch (427 Bytes) DataHandler.patch Uwe Wiebach, 2013-11-25 13:11

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #21043: itemsProcFunc for Radio-Buttons doesn't work correctlyClosed2009-09-12

Actions
Actions #1

Updated by Stefan Galinski almost 11 years ago

Hi Uwe,

Please upload your patch to the review system. You can find detailed instructions in the TYPO3 wiki on the page http://wiki.typo3.org/Contribution_Walkthrough_(Git).

Actions #2

Updated by Stefan Galinski almost 11 years ago

  • TYPO3 Version changed from 6.2 to 4.5
Actions #3

Updated by Uwe Wiebach almost 11 years ago

Done (https://review.typo3.org/25867). I hope I did everything correctly (my first contribution) ...

Actions #4

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26992

Actions #5

Updated by Uwe Wiebach almost 11 years ago

As you changed the TYPO3 version to 4.5 I pushed a patch for this branch to Git ...

Actions #6

Updated by Alexander Opitz almost 11 years ago

You pushed it to master and not into the right branch.

Also your review https://review.typo3.org/#/c/25867/ seams to have a little problem (You didn't used "Resolves" in commit message, fixed that), as it isn't shown here.
The change of the TYPO3 Version only means, that this issue exists since this version.

In #21043 was no answer, as it was closed (course there was no response).

By the way, I don't think that this issue will be backported to 4.5 or 4.7 as they will only receive security fixes.

Actions #7

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25867

Actions #8

Updated by Uwe Wiebach almost 11 years ago

Thanks for clarifying!

Actions #9

Updated by Gerrit Code Review almost 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/25867

Actions #10

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/25867

Actions #11

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/25867

Actions #12

Updated by Andreas Wolf over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41642

Actions #14

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41642

Actions #15

Updated by Mathias Schreiber over 8 years ago

  • Status changed from Under Review to New
Actions #16

Updated by Mathias Schreiber over 8 years ago

  • Status changed from New to Closed

Use FormEngine DataProcessors :)

Actions

Also available in: Atom PDF