Task #54726

Epic #55070: Workpackages

Epic #54260: WP: FAL Missing Issues / Features / API

Story #54266: As an User I want FAL to be performant

Task #51094: SQL-Optimize the FAL

sys_file_reference.fieldname optimize columns

Added by Ingo Schmitt almost 6 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Ingo Schmitt
Category:
Performance
Target version:
6.2.0
Start date:
2014-01-03
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

MySQL up to 5.5 allows at maximum 64 characters for tablenames and fieldnames [1], thus no other DBAL implementation should use more than 64 characters.

This leads set the maximum size of the fields tablenames and fieldname to 64 chars.
The field sys_file_reference.fieldname should be varchar or char, not TINYTEXT.
since only fieldnames from the database are stored varchar(64) should be enough.

[1] http://dev.mysql.com/doc/refman/5.5/en/identifiers.html

Related issues

Blocks TYPO3 Core - Task #54725: Add Indexes to sys_file_reference Closed 2014-01-03

Associated revisions

Revision 9e88bf74 (diff)
Added by Ingo Schmitt almost 6 years ago

[TASK] Optimize columns in sys_file_reference

MySQL up to version 5.5 allows at maximum 64 characters for table-
and fieldnames. Other DBMS allow less. Since MySQL is our primary
database and DBAL could handle specialties.

This patch changes the fields tablenames, fieldname and table_local
to varchar(64) which currently is considered save.

Resolves: #54726
Releases: 6.2
Change-Id: Ic67450a9326dceb413fe694a6233b8c092f70c79
Reviewed-on: https://review.typo3.org/26625
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

History

#1 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26625

#2 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26625

#3 Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26625

#4 Updated by Markus Klein almost 6 years ago

  • Subject changed from sys_file_reference.fieldname otimize colums to sys_file_reference.fieldname optimize columns

#5 Updated by Steffen Ritter almost 6 years ago

  • Parent task set to #51094

#6 Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26625

#7 Updated by Ingo Schmitt almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Steffen Ritter almost 6 years ago

  • % Done changed from 100 to 90

#9 Updated by Steffen Ritter almost 6 years ago

  • Assignee set to Ingo Schmitt

#10 Updated by Steffen Ritter over 5 years ago

  • % Done changed from 90 to 100

#11 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF