Bug #55113: TCA pages->subtitle: eval trim missing - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #55113

closed

TCA pages->subtitle: eval trim missing

Added by Andreas Kießling almost 11 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Backend User Interface

Target version:

Start date:

2014-01-17

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.5

PHP Version:

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

I just compared the TCA settings for pages and pages_language_overlay for the field subtitle. pages has no eval setting, while pages_language_overlay has it set to trim.

This causes trouble, if you output the field like this:

10 = TEXT
10 {
  data = page:subtitle // page:title
...

and resulted in an empty TEXT object.

I'd suggest to add trim to subtitle in pages and make it behave like in pages_language_overlay

Actions

Copy link

Updated by Markus Klein almost 11 years ago

The trim on the overlay was introduced with #24386 on 12.1.2011
https://git.typo3.org/Packages/TYPO3.CMS.git/commit/c442a3ebc567d43becb7ca6fdd9c3290149f1a9d

Actions

Copy link

Updated by Andreas Kießling almost 11 years ago

Looks like this was done accidently, but makes sense nevertheless

Actions

Copy link

Updated by Jo Hasenau almost 11 years ago

Actually it's the other way around: The setting for pages=>subtitle has been missing accidentally while we changed the TCA settings after T3UXW09.

Usually any field that will be output as text but does not need additional whitespace with linebreaks or the like, should get trim as eval setting.

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26933

Actions

Copy link