Task #55186

Epic #55070: Workpackages

Epic #54260: WP: FAL Missing Issues / Features / API

Story #54266: As an User I want FAL to be performant

Task #54225: Optimize Performance and DB Queries for FAL

Prevent Storages to be queried over and over again

Added by Steffen Ritter over 5 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Must have
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2014-01-20
Due date:
% Done:

100%

Estimated time:
3.00 h
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The Backend as well as the frontend queries for storages many times.

There are most times not many storages within the system.

The idea is, to create all storages objects at once as soon as the first one is requested and store them in memory...
Therefore many queries may be omitted.


Related issues

Related to TYPO3 Core - Bug #56400: Finding a storage by storage type fails Closed 2014-02-27
Precedes TYPO3 Core - Bug #55992: StorageRepository fails to load storages if new one is created Closed 2014-02-14

Associated revisions

Revision 3e8eacec (diff)
Added by Steffen Ritter over 5 years ago

[TASK] Optimize retrieval of Storages

Analysing the SQL logs shows that there are very much queries to the
sys_file_storage even though the information is quite static. Since
there in general there are not much storages - in most cases it only
will be fileadmin/.

This change will get all storage records from database with one call
and cache this in a runtime cache. Afterwards all requests are resolved
by the static member variable of the StorageRepository. If no storage
is present the default storage is created

Resolves: #55186
Releases: 6.2
Change-Id: I066b57215ba39f7cad608cfe5e83a0f3508b2c62
Reviewed-on: https://review.typo3.org/27025
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27025

#2 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27025

#3 Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27025

#4 Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27025

#5 Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27025

#6 Updated by Steffen Ritter over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF