Task #55983

Cleanup init() function of ElementBrowser

Added by Tymoteusz Motylewski almost 6 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Code Cleanup
Target version:
-
Start date:
2014-02-14
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Right now the init() function of the element browser has ~450 lines :)
We should refactor it in the similar way it was already done in SelectImage and BrowseLinks.
This will also allow us to remove duplicate code between these classes.


Related issues

Related to TYPO3 Core - Bug #56860: RTE page browser jumps to external URL on fold / unfolding the pagetree Closed 2014-03-13
Related to TYPO3 Core - Bug #59199: Element Browser: GET-Data is not unencoded in fields Closed 2014-05-29

Associated revisions

Revision 1415f45e (diff)
Added by Tymoteusz Motylewski almost 6 years ago

[TASK] Refactor init() function of ElementBrowser

Splits huge method (~450 lines) into several small methods,
in the similar way it was done for BrowseLinks and SelectImage.

It also removes some duplicated code between these classes.
This patch is not changing functionality, just moving code around.

Resolves: #55983
Releases: 6.2
Change-Id: I916058485acb9d9abe0086785763edc721a360f0
Reviewed-on: https://review.typo3.org/27631
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27631

#2 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27631

#3 Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27631

#4 Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27631

#5 Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27631

#6 Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27631

#7 Updated by Gerrit Code Review almost 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27631

#8 Updated by Gerrit Code Review almost 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27631

#9 Updated by Gerrit Code Review almost 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27631

#10 Updated by Tymoteusz Motylewski almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Alexander Stehlik almost 6 years ago

Regression in #56860

#12 Updated by Markus Klein over 5 years ago

Regression in #59199

#13 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF