Project

General

Profile

Actions

Bug #56483

closed

INCLUDE_TYPOSCRIPT fails on files that begin with a BOM

Added by Stefan Neufeind over 10 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
TypoScript
Target version:
-
Start date:
2014-03-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:
On Location Sprint

Description

Files need to be in UTF-8. But editors like "notepad" by default write a BOM and there is no easy way to see there are "hidden characters" in the beginning of the file.

In the typoscript-editor no problems are visible. But template-analyser complains about some special character in the first like of the file.

Imho INCLUDE_TYPOSCRIPT should handle a BOM gracefully (skipping the BOM when reading - maybe on save just saving the file without any BOM as it does now).


Files

Schermata 2017-01-22 alle 00.15.09.png (29.9 KB) Schermata 2017-01-22 alle 00.15.09.png Riccardo De Contardi, 2017-01-22 00:16
Actions #1

Updated by Riccardo De Contardi over 9 years ago

  • TYPO3 Version changed from 6.1 to 6.2

Still present in TYPO3 6.2.12; this is the error shown in TSOB:

Errors and warnings
2:    Line 2748: Object Name String, "page.5" contains invalid character "�". Must be alphanumeric or one of: "_:-\." Show details
Actions #2

Updated by Riccardo De Contardi about 9 years ago

the error is still present in 6.2.15 and 7.6-dev (latest master)

on 7.6 the explanation of the error is missing in TSOB: it merely says:

"
Errors and warnings
Show details
"

Actions #3

Updated by Riccardo De Contardi almost 8 years ago

Issue is still present on 8.6-dev (latest master); the error message in TSOB is still

Errors and warnings
Warning : Show details 

when I click on "show details" I am redirected to the Template Analyzer where the error is reported as on the attached screenshot

Actions #4

Updated by Riccardo De Contardi about 7 years ago

  • Complexity set to easy
Actions #5

Updated by Susanne Moog over 6 years ago

  • Sprint Focus set to On Location Sprint
Actions #6

Updated by Frank Nägler over 6 years ago

  • Assignee set to Andreas Kienast
Actions #7

Updated by Andreas Kienast over 6 years ago

FYI: a BOM may be added by running vim -e -s -c ':set bomb' -c ':wq' foo.typoscript in a terminal

Actions #8

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57315

Actions #9

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57315

Actions #10

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57315

Actions #11

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57315

Actions #12

Updated by Andreas Fernandez over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57327

Actions #14

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57327

Actions #15

Updated by Andreas Fernandez over 6 years ago

  • Status changed from Under Review to Resolved
Actions #16

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF