Bug #56933

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Bug #52949: Speed decrease since 4.5

Bug #56307: Findings from Bootstrap/PackageManager/ClassLoader analyses

Cached class loader misses are not considered on retrieval

Added by Thomas Maroschik over 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2014-03-15
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The class loader caches if he didn't find a class name for subsequent calls. But currently it only checks for NULL results from the cache and not the empty strings returned from the cache and thus tries to resolve the non existing class name over and over again.


Related issues

Related to TYPO3 Core - Bug #57094: TCA eval 'int+' fails with a fatal error Rejected 2014-03-20
Related to TYPO3 Core - Bug #57117: Class loader must handle information about invalid classes Closed 2014-03-20

Associated revisions

Revision 15df568f (diff)
Added by Thomas Maroschik over 5 years ago

[BUGFIX] Cached class loader misses are not considered

The class loader caches if it doesn't find a class name
for subsequent calls. But currently it only checks for
NULL results from the cache and not the empty strings
returned from the cache and thus tries to resolve the
non existing class name over and over again.

The fix converts the empty string to a NULL and
changes the semantics of NULL to FALSE in the class
loader.

Fixes: #56933
Releases: 6.2
Change-Id: I4cd1a18b4a4496c287a937d6d9882ae21d3ee9a3
Reviewed-on: https://review.typo3.org/28419
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Revision baebd056 (diff)
Added by Markus Klein over 5 years ago

[BUGFIX] Class loader handles information about invalid classes

Resolves: #57117
Related: #56933
Releases: 6.2
Change-Id: Ie305b808b0a9b9e10b5adca4af9e2562cf5123f6
Reviewed-on: https://review.typo3.org/28577
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Revision 274e7eea (diff)
Added by Helmut Hummel over 5 years ago

[FOLLOWUP] Class loader handles invalid classes

The check if we have class information
can be simplified to !empty()

Resolves: #57117
Related: #56933
Releases: 6.2
Change-Id: I8532b26142cc39da2b9bcca9880df715da57d59e
Reviewed-on: https://review.typo3.org/28596
Reviewed-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

History

#1 Updated by Gerrit Code Review over 5 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28419

#2 Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28419

#3 Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28419

#4 Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28419

#5 Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28419

#6 Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28419

#7 Updated by Gerrit Code Review over 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28419

#8 Updated by Gerrit Code Review over 5 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28419

#9 Updated by Gerrit Code Review over 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28419

#10 Updated by Gerrit Code Review over 5 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28419

#11 Updated by Gerrit Code Review over 5 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/28419

#12 Updated by Thomas Maroschik over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#13 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF