Project

General

Profile

Actions

Bug #56982

closed

files copied for local processing are not deleted

Added by Christian Weiske about 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2014-03-17
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:
Remote Sprint

Description

TYPO3\CMS\Core\Resource\Processing\LocalPreviewHelper makes FAL storage adapters copy files locally to generate a preview image. It uses getFileForLocalProcessing for that.

After generating the preview, the file stays on the local file system and does not get deleted. This causes the local file system to fill up with unneeded files.

The temporarily locally copied file should get deleted after the preview image has been generated.

This happens with TYPO3 6.2beta7.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #62098: typo3temp folder is flooded with fal-tempfiles-*.*Closed2014-10-08

Actions
Actions #1

Updated by Steffen Ritter about 10 years ago

  • Status changed from New to Accepted
  • Complexity set to no-brainer

$originalFileName = $sourceFile->getForLocalProcessing(FALSE);

means: file is not copied - this only would happen for remote storages....

so we could fix the LOCALpreviewhelper for REMOTE storages - but that's not urgent atm.

Actions #2

Updated by Steffen Ritter about 10 years ago

  • Target version set to 2702
Actions #3

Updated by Steffen Ritter about 10 years ago

  • Target version deleted (2702)
Actions #4

Updated by Frans Saris over 9 years ago

  • Sprint Focus set to On Location Sprint

In TYPO3\CMS\Core\Resource\Processing\LocalPreviewHelper::process() a check should be added that removes $originalFileName if it isn't the original file but a copy of it in typo3temp.

Actions #5

Updated by Frans Saris over 9 years ago

  • Status changed from Accepted to New
Actions #6

Updated by Mathias Schreiber about 9 years ago

  • Status changed from New to In Progress
Actions #7

Updated by Gerrit Code Review about 9 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36446

Actions #8

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36446

Actions #9

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36446

Actions #10

Updated by Gerrit Code Review about 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36446

Actions #11

Updated by Gerrit Code Review about 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36446

Actions #12

Updated by Gerrit Code Review about 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36446

Actions #13

Updated by Gerrit Code Review about 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36446

Actions #14

Updated by Gerrit Code Review about 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36446

Actions #15

Updated by Anja Leichsenring over 8 years ago

  • Sprint Focus changed from On Location Sprint to Remote Sprint
Actions #16

Updated by Gerrit Code Review over 8 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36446

Actions #17

Updated by Gerrit Code Review almost 8 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/36446

Actions #18

Updated by Riccardo De Contardi over 5 years ago

  • Status changed from Under Review to Closed

Closed for now - patch has been abandoned - see comments on https://review.typo3.org/36446

If you think that this is the wrong decision please reopen or ping me. Thank you.

Actions

Also available in: Atom PDF