Task #59015

Story #58777: Fixes/Tasks for impexp / distributions

Catch all errors on adding files of sys_files to export

Added by Marc Bastian Heinrichs over 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Import/Export (T3D)
Target version:
-
Start date:
2014-05-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Adding files from sys_file records is not robust enough.
E.g. if there are sys_file records, but no related files anymore, what
could happen for files in /uploads/tx_foo till #58967 is fixed a RuntimeException
is thrown.

Solution: catch all Exceptions thrown from Resources in export_addSysFile


Files

2014-05-22_1124.png (45.8 KB) 2014-05-22_1124.png Armin Vieweg, 2014-05-22 11:25
#1

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30318

#2

Updated by Armin Vieweg over 6 years ago

I've tested it, now I get this warning in ImpExp module:

Core: Error handler (BE): PHP Warning: fileperms(): stat failed for /var/www/vhosts/.../htdocs/htdocs
in /var/www/t3sources/typo3_src-6.2.2/typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php line 1097

And for every time I open the ImpExp module again (for root node) another warning appears:

In this example I've opened the module six times. I've also opened it on other pages, then it works. But when I switch back to root, a new warning appears additionally.

#3

Updated by Marc Bastian Heinrichs over 6 years ago

Ok, thx for testing. Perhaps we should prevent php warnings for fileperms...

Could give some details? You are on Win or Linux? What storages are configured?

#4

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30318

#5

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30318

#6

Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/30318

#7

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/37566

#8

Updated by Marc Bastian Heinrichs almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Anja Leichsenring about 5 years ago

  • Sprint Focus set to On Location Sprint
#10

Updated by Mathias Schreiber over 4 years ago

  • Sprint Focus deleted (On Location Sprint)
#11

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF