Bug #59432
closed
setLocalConfigurationValueByPath() writes LocalConfiguration.php on each request
0%
Description
Hi,
Since TYPO3 6.0 it is recommended to not use $GLOBALS['TYPO3_CONF_VARS'], but TYPO3\CMS\Core\Configuration\ConfigurationManager to set and get values from LocalConfiguration.php (and AdditionalCOnfiguration.php).
However, I've found one strange behaviour of ConfigurationManager. Whenever someone uses setLocalConfigurationValueByPath() or setLocalConfigurationValuesByPathValuePairs() ConfigurationManager implicitly writes LocalConfiguration.php. Meaning, that if setLocalConfigurationValueByPath() is invoked from ext_localconf.php, this will cause LocalConfigration.php writes on each request.
Isn't it possible to do a pre-check in set() methods, that option is already set to desired value?
Updated by Uwe Trotzek over 9 years ago
- Target version set to next-patchlevel
I would say it's a must have because this behaviour leads to the related issues. When one uses setLocalConfigurationValuesByPathValuePairs multitple times in AdditionalConfigiration it could cause an exception because the LocalConfiguration could not be fully written before it's read by another parallel task.
In my opinion the setLocalConfigurationValuesByPathValuePairs should be refactored to not write the additional config to the local config physically. I don't know if it's technically possible.
Updated by Mathias Schreiber over 8 years ago
- Target version deleted (
next-patchlevel)
Updated by Christian Kuhn over 7 years ago
wrong usage. the whole class "ConfigurationManager" is marked as @internal. Cite from class head:
* IMPORTANT: * This class is intended for internal core use ONLY. * Extensions should usually use the resulting $GLOBALS['TYPO3_CONF_VARS'] array, * do not try to modify settings in LocalConfiguration.php with an extension. * @internal