Bug #61144
closed
Trailing comma in arrays causes exception
100%
Description
Given the following viewhelper invocation:
<f:render partial="Foo" arguments="{
foo: 1,
bar: 2,
}"/>
Fluid throws an exception like this due to the trailing comma:
#1237900529: The argument "arguments" was registered with type "array", but is of type "string" in view helper "TYPO3\CMS\Fluid\ViewHelpers\RenderViewHelper"
While the array above may not be valid in JSON, it is fully valid in JavaScript. Given the fact that the only other piece of software that chokes on this is the Internet Explorer (at least ancient versions) I'd opt for allowing this.
Updated by Stefan Froemken about 10 years ago
I don't like this approach. I don't like it for PHP, for JavaScript and I think it's not good to have that for Fluid-Arguments. But at least the core-Team has to decide.
Updated by Mathias Brodala about 10 years ago
There are a few nice things, if trailing commas are allowed:
- you can easily add, remove or reorder lines without having to worry about missing or extra commas
- SCM like git only show one line changed instead of two on add/remove
What do you think about these?
Updated by Mathias Brodala almost 10 years ago
Any other opinions on this one, especially wrt the points I've mentioned?
Updated by Alexander Schnitzler almost 10 years ago
I fully agree. In an environment that is usually very forgiving (PHP, JS) it's very uncommon to have this and makes using fluid more error prone that is should be. I'm saying this because compared to the template engine PHP (sic!) fluid is very strict for no reason at all and throws to much exceptions.
Updated by Gerrit Code Review about 9 years ago
- Status changed from New to Under Review
Patch set 39 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 40 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 41 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 42 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Mathias Schreiber about 9 years ago
- Target version deleted (
next-patchlevel)
Updated by Gerrit Code Review about 9 years ago
Patch set 43 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 44 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 45 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 46 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 47 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 48 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 49 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 50 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 51 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 52 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 53 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review about 9 years ago
Patch set 54 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 55 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 56 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 57 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 58 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 59 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 60 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 61 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 62 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 63 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 64 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 65 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 66 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 67 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 68 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 69 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 70 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 71 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 72 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 73 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 74 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 75 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 76 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 77 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 78 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 79 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 80 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 81 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 82 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 83 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 84 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 85 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 86 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 87 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 88 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 89 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 90 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 91 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 92 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 93 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 94 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 95 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 96 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 97 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 98 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 99 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 100 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 101 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 102 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 103 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 104 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 105 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 106 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 107 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 108 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 109 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 110 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 111 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 112 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 113 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 114 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 115 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 116 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 117 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 118 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 119 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 120 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 121 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 122 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 123 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 124 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 125 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 126 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 127 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 128 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 129 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 130 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Gerrit Code Review almost 9 years ago
Patch set 131 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/42425
Updated by Anonymous almost 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 8b693daac0cc381f10c74bc5d78b2448f55111f3.
Updated by Benni Mack about 6 years ago
- Status changed from Resolved to Closed