Project

General

Profile

Actions

Bug #61298

closed

Missing stylesheet admin_panel.css in page if hide=1 for user group in frontend editing leads to missing editing icons

Added by Byggwir no-lastname-given about 10 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
Start date:
2014-09-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Yes
Sprint Focus:

Description

After updating from Version 6.1 to 6.2.4 a user group doesn't see the editing icons in frontend editing anymore if admPanel.hide=1.
In 6.1 this group had editing icons beneath the copy content but didn't have the admin panel visible.
(The commands for editing are there as underscore but the icons are missing.)

Looks like the way to display the editing icons changed. Now a stylesheet is included "admin_panel.css" in case the admin panel shall be shown (hide=0).
And the img tag of 6.1 to display the editing icons is now a span with typo3 classes to display the icons.
This stylesheet contains the icons for editing content. If it is not included the icons are missing.

If a user group defines a "admPanel.hide=1" to hide the admin panel in the lower left side of frontend editing then the icons vanish as well. The commands for editing are available but the classes of the "span" are not available.

Reproduce:
Create an "editor group" and add to options:

admPanel {
enable.edit = 1
override.edit.displayIcons = 1
override.edit.forceDisplayIcons = 1
override.edit.forceDisplayFieldIcons = 1
hide = 1
}

Open a page in frontend editing to see effect. Toggle "hide" to see the difference.

Actions #1

Updated by Markus Klein about 10 years ago

  • Category set to Frontend
  • Status changed from New to Accepted
  • Target version set to next-patchlevel
  • Complexity set to easy

typo3/sysext/cms/tslib/index_ts.php line 268 ff needs adaption.
The check needs to be separated into 'enabled' and 'visible'

Actions #2

Updated by Mathias Schreiber almost 10 years ago

  • Target version changed from next-patchlevel to 7.1 (Cleanup)
Actions #3

Updated by Benni Mack over 9 years ago

  • Target version changed from 7.1 (Cleanup) to 7.4 (Backend)
Actions #4

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40922

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40922

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40922

Actions #7

Updated by Gerrit Code Review about 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/40922

Actions #8

Updated by David Greiner about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Riccardo De Contardi almost 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF