Bug #64449: f:switch very slow since it does not implement CompilableInterface interface - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #64449

closed

Epic #65429: Speed up for Fluid ViewHelpers by usage of CompilableInterface

f:switch very slow since it does not implement CompilableInterface interface

Added by Christian Weiske almost 10 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Fluid

Target version:

7.2 (Frontend)

Start date:

2015-01-23

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

The Fluid SwitchViewHelper (<f:switch>) does not implement CompilableInterface. This prevents the TemplateParser from caching it, making template rendering unbearably slow.

<f:if> on the other hand does implement the interface (through AbstractConditionViewHelper) and gets cached properly.

<f:switch> should be cached!

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Mathias Schreiber almost 10 years ago

Target version set to 7.2 (Frontend)

Actions

Copy link

Updated by Christian Weiske almost 10 years ago

Btw, simply adding an "implements ..." line to the class declaration leads to bugs in the output.

Actions

Copy link

Updated by Christian Kuhn almost 10 years ago

Yes. This is not only this specific view helper, there are much more. I'm currently working on a fresh backport from TYPO3.fluid that has much more compilable interfaces implemented already, you can expect a patch in this area soon.

Actions

Copy link

Updated by Christian Kuhn almost 10 years ago

if backport is done, a couple of other view helpers that did not yet have been fixed in fluid upstream will be changed for cms core locally. the performance boost is just too high to wait for upstream at this point ... give me some time and expect this issue to be fixed soon. i'll ping you for reviews if you find the time, Christian.

Actions

Copy link

Updated by Anja Leichsenring over 9 years ago

Parent task set to #65429

Actions

Copy link

Updated by Bastian Waidelich over 9 years ago

Hi,

that is a problem indeed. The actual issue is not that the ViewHelper itself is not compilable, but that it also implements the {ChildNodeAccessInterface}} which - in combination - leads to the whole template file not being compiled. (see https://jira.typo3.org/browse/FLOW-224).
BTW: The same is true when using widgets, but in those cases the issue is probably very hard to solve unfortunately (see https://jira.typo3.org/browse/FLOW-196).

Actions

Copy link