TYPO3 Core

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36720

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36720

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36720

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36722

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36722

According to a clients information the import of the l10nmgr is broken with 6.2.10 and I tracked it down to this change

The problem is the new behavour in line 225 of FlexFormTools.php
The old version handed over $this as reference, the new one puts it into an array.

Results in

PHP Warning: 
Parameter 5 to tx_l10nmgr_tools::translationDetails_flexFormCallBackForOverlay()
expected to be a reference, value given in 
/domains/typo3_src/typo3_src-6.2.10/typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php line 242

Jo Hasenau wrote:

According to a clients information the import of the l10nmgr is broken with 6.2.10 and I tracked it down to this change

The problem is the new behavour in line 225 of FlexFormTools.php
The old version handed over $this as reference, the new one puts it into an array.

Results in
[...]

Which PHP version are you using? Seems not being consistent through recent versions...

The problem seems to be that "call_user_func_array" does not honor the destination function signature so parameters are always passed by value. The extra function was introduced to be able to add unit testing to the patch but this is indeed a nasty side effect.

(see http://php.net/manual/en/function.call-user-func-array.php#refsect1-function.call-user-func-array-notes)

In the meanwhile you may replace the calls to "$this->executeCallBackMethod" with the former method or changing the receiving function so it expects its 5th parameter to be passed by value (changing "&$param" to "$param")