Project

General

Profile

Actions
Copy link

Task #65543

closed

Looks error page frontend

Added by Job Rutgers over 9 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
7 LTS
Start date:
2015-03-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The looks of the error messages on the frontpage should be refreshed. With typo3-message message-error class.

Files

Download all files
error_page.png (21.9 KB) error_page.png Job Rutgers, 2015-03-05 14:41
error_before.png (21.6 KB) error_before.png Björn Jacob, 2015-11-19 16:34
error_after.png (19.3 KB) error_after.png Björn Jacob, 2015-11-19 16:34
blue-message.png (62.9 KB) blue-message.png Harry Glatz, 2015-11-19 21:36
error_no_description.png (5.02 KB) error_no_description.png Björn Jacob, 2015-11-19 21:47
Actions
Copy link
 #1

Updated by Jigal van Hemert over 9 years ago

  • Category set to Backend User Interface

Although this is about the frontend error messages, the styling is directly related/retrieved from the backend styling; therefore the Category "Backend User Interface".

Actions
Copy link
 #2

Updated by Benni Mack over 9 years ago

  • Target version changed from 7.2 (Frontend) to 7.4 (Backend)
Actions
Copy link
 #3

Updated by Susanne Moog over 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions
Copy link
 #4

Updated by Benni Mack about 9 years ago

  • Target version changed from 7.5 to 7 LTS
Actions
Copy link
 #5

Updated by Gerrit Code Review about 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243

Actions
Copy link
 #6

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243

Actions
Copy link
 #7

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243

Actions
Copy link
 #8

Updated by Gerrit Code Review about 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243

Actions
Copy link
 #9

Updated by Gerrit Code Review about 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243

Actions
Copy link
 #10

Updated by Gerrit Code Review about 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243

Actions
Copy link
 #11

Updated by Gerrit Code Review about 9 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243

Actions
Copy link
 #12

Updated by Gerrit Code Review about 9 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243

Actions
Copy link Download all files
 #13

Updated by Björn Jacob about 9 years ago

Check the attatched screenshots.

The last screenshot shows the vertically centered title. This is possible if .media-body gets a vertical-align: middle; and the p tag inside .callout-body is removed.

Actions
Copy link
 #14

Updated by Harry Glatz about 9 years ago

I added a message which exactly uses this code we have right now. so i think this is ok right now.

Actions
Copy link
 #15

Updated by Björn Jacob about 9 years ago

Your images are correct but are not the same. Because your messages have a description and that's why the title is pushed to the top. Within this ticket we've got no description and therefore only a title. Please see my attatched image (displays an alert which we also have in our error case).

Actions
Copy link
 #17

Updated by Harry Glatz about 9 years ago

you are right. but at least there is a marker for ###MESSAGE### - so template-wise there could be a message :)

As discussed in slack this vertical-align only makes sense if it is checked wether there is a message or not.

Actions
Copy link
 #18

Updated by Gerrit Code Review about 9 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243

Actions
Copy link
 #19

Updated by Gerrit Code Review about 9 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243

Actions
Copy link
 #20

Updated by Gerrit Code Review about 9 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243

Actions
Copy link
 #21

Updated by Anonymous almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #22

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF