Task #65543
closed
Looks error page frontend
Added by Job Rutgers about 9 years ago. Updated over 6 years ago.
100%
Description
The looks of the error messages on the frontpage should be refreshed. With typo3-message message-error class.
Files
| error_page.png (21.9 KB) error_page.png | Job Rutgers, 2015-03-05 14:41 | ||
| error_before.png (21.6 KB) error_before.png | Björn Jacob, 2015-11-19 16:34 | ||
| error_after.png (19.3 KB) error_after.png | Björn Jacob, 2015-11-19 16:34 | ||
| blue-message.png (62.9 KB) blue-message.png | Harry Glatz, 2015-11-19 21:36 | ||
| error_no_description.png (5.02 KB) error_no_description.png | Björn Jacob, 2015-11-19 21:47 |
Updated by Jigal van Hemert about 9 years ago
- Category set to Backend User Interface
Although this is about the frontend error messages, the styling is directly related/retrieved from the backend styling; therefore the Category "Backend User Interface".
Updated by Benni Mack almost 9 years ago
- Target version changed from 7.2 (Frontend) to 7.4 (Backend)
Updated by Susanne Moog over 8 years ago
- Target version changed from 7.4 (Backend) to 7.5
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243
Updated by Gerrit Code Review over 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243
Updated by Gerrit Code Review over 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243
Updated by Gerrit Code Review over 8 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243
Updated by Gerrit Code Review over 8 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243
Updated by Gerrit Code Review over 8 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243
Updated by Gerrit Code Review over 8 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243
Updated by Björn Jacob over 8 years ago
- File error_before.png error_before.png added
- File error_after.png error_after.png added
- File error_before.png error_before.png added
- File error_after.png error_after.png added
Check the attatched screenshots.
The last screenshot shows the vertically centered title. This is possible if .media-body gets a vertical-align: middle; and the p tag inside .callout-body is removed.
Updated by Harry Glatz over 8 years ago
- File blue-message.png blue-message.png added
- File blue-message.png blue-message.png added
I added a message which exactly uses this code we have right now. so i think this is ok right now.
Updated by Björn Jacob over 8 years ago
Your images are correct but are not the same. Because your messages have a description and that's why the title is pushed to the top. Within this ticket we've got no description and therefore only a title. Please see my attatched image (displays an alert which we also have in our error case).
Updated by Björn Jacob over 8 years ago
- File error_no_description.png error_no_description.png added
- File error_no_description.png error_no_description.png added
Updated by Harry Glatz over 8 years ago
you are right. but at least there is a marker for ###MESSAGE### - so template-wise there could be a message :)
As discussed in slack this vertical-align only makes sense if it is checked wether there is a message or not.
Updated by Gerrit Code Review over 8 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243
Updated by Gerrit Code Review over 8 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243
Updated by Gerrit Code Review over 8 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/44243
Updated by Anonymous over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset e1b1578a578f8139ecad98c3a2d5c9ead64540f3.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed