Bug #66669

Possibility to extend/override New login screen

Added by Benjamin Serfhos over 4 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2015-05-16
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:
Stabilization Sprint

Description

Before the backend login screen template could be overriden with the following configuration:
$GLOBALS['TBE_STYLES']['htmlTemplates']['EXT:backend/Resources/Private/Templates/login.html']

This does not seem to work anymore cause of the Fluid rendering atm.

Please add signals for modifying the view object to make the login screen extendable again.

Screen Shot 2015-05-01 at 08.44.23.png View (69.6 KB) Benjamin Serfhos, 2015-05-01 08:45


Subtasks

Task #66997: Remove login security levels super-/challengedClosedMarkus Klein


Related issues

Related to TYPO3 Core - Feature #66431: New Login Screen Closed 2015-04-17
Related to TYPO3 Core - Bug #51308: Allow registration of different backend login forms Closed 2013-08-23
Related to TYPO3 Core - Bug #67321: BE login form does not redirect if already authenticated Closed 2015-06-05
Related to TYPO3 Core - Bug #67440: Correct typo in code example (ChangeLog files) Rejected 2015-06-14

Associated revisions

Revision 9099b64c (diff)
Added by Frank Naegler over 4 years ago

[!!!][FEATURE] BE Login form API

With the new login screen (introduced in 7.2) the possibility to
override or extend the login template was removed.
The old globals ``$GLOBALS['TBE_STYLES']['htmlTemplates']`` was
removed without replacement.

With this patch we introduce a new way to extend the login form and
add a BE login form API.

Resolves: #66669
Releases: master
Change-Id: I36ab4cdabbab55f370d1fd19b7212cf2f858db57
Reviewed-on: http://review.typo3.org/39234
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Frank Nägler <>
Tested-by: Frank Nägler <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision a7205dac (diff)
Added by Frank Naegler over 4 years ago

[BUGFIX] BE-Login: redirect if already authenticated

Resolves: #67321
Related: #66669
Releases: master
Change-Id: Ib8de4463194a304467b06d3d0c00f42943e6b8d5
Reviewed-on: http://review.typo3.org/40037
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

History

#1 Updated by Frank Naegler over 4 years ago

  • Status changed from New to Needs Feedback

Hello Benjmain,
thanks for your feedback. Please can you explain why you need this?

#2 Updated by Benjamin Serfhos over 4 years ago

So people can have their own option besides the regular option (LDAP or any other system).
For our internal colleagues we have our own generic SSO, but for external they can use the default TYPO3 environment.

See screenshot for our TYPO3 mainscreen (7.1).

#3 Updated by Torben Hansen over 4 years ago

The template must be overridable, so you can use other authentication services (e.g. two factor) with the TYPO3 backend login, which require extra fields (example: http://typo3.org/extensions/repository/view/sf_yubikey)

Before #65939, you could override the template by using:

$TBE_STYLES['htmlTemplates']['EXT:backend/Resources/Private/Templates/login.html'] = 'path/To/NewTemplate.html';

Now it is not possible any more.

This problem can easily be solved, if the new login controller respects the template set in TBE_STYLES. The main function could be extended as shown below.

$template = 'EXT:backend/Resources/Private/Templates/Login.html';
if (isset($GLOBALS['TBE_STYLES']['htmlTemplates']['EXT:backend/Resources/Private/Templates/login.html']) &&
    file_exists($GLOBALS['TBE_STYLES']['htmlTemplates']['EXT:backend/Resources/Private/Templates/login.html'])) {
    $template = $GLOBALS['TBE_STYLES']['htmlTemplates']['EXT:backend/Resources/Private/Templates/login.html'];
}
$view = $this->getFluidTemplateObject($template);

I'll create a patch for this change.

#4 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39192

#5 Updated by Benjamin Serfhos over 4 years ago

Hi Torben,

I would suggest to use signals instead of the globals template configuration.

If you can change the view object you can add own variables too.

Kind regards,

Benjamin

#6 Updated by Torben Hansen over 4 years ago

Hi Benjamin,

yes, that would indeed be an option / a better solution.

What I'm missing here is a note, that the TBE_STYLES have been deprecated for the loginController. The only thing I could find is was this note about the backend login form:

https://github.com/TYPO3/TYPO3.CMS/blob/cb7a7498566ab22266a4088bf009eabb5eb27372/typo3/sysext/core/Documentation/Changelog/7.2/Breaking-65939-BackendLoginRefactoring.rst

As not taking TBE_STYLES into respect is a breaking change, there should be a fallback / replacement for it. Also (if there is no fallback for TBE_STYLES), it should be noted as a breaking change, since I believe there are some extensions out there using TBE_STYLES to add a custom loginform.

Best regards
Torben

#7 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#8 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#9 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#10 Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#11 Updated by Gerrit Code Review over 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#12 Updated by Gerrit Code Review over 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#13 Updated by Gerrit Code Review over 4 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#14 Updated by Gerrit Code Review over 4 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#15 Updated by Gerrit Code Review over 4 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#16 Updated by Gerrit Code Review over 4 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#17 Updated by Gerrit Code Review over 4 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#18 Updated by Gerrit Code Review over 4 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#19 Updated by Gerrit Code Review over 4 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#20 Updated by Gerrit Code Review over 4 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#21 Updated by Gerrit Code Review over 4 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#22 Updated by Gerrit Code Review over 4 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#23 Updated by Gerrit Code Review over 4 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#24 Updated by Gerrit Code Review over 4 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#25 Updated by Gerrit Code Review over 4 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#26 Updated by Gerrit Code Review over 4 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#27 Updated by Gerrit Code Review over 4 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#28 Updated by Gerrit Code Review over 4 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#29 Updated by Frank Naegler over 4 years ago

  • Target version changed from 7.2 (Frontend) to 7.3 (Packages)
  • Sprint Focus set to Stabilization Sprint

#30 Updated by Gerrit Code Review over 4 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#31 Updated by Gerrit Code Review over 4 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#32 Updated by Gerrit Code Review over 4 years ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#33 Updated by Gerrit Code Review over 4 years ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#34 Updated by Gerrit Code Review over 4 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234

#35 Updated by Frank Naegler over 4 years ago

  • Status changed from Under Review to Resolved

#36 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF