Bug #66669
closedPossibility to extend/override New login screen
100%
Description
Before the backend login screen template could be overriden with the following configuration:
$GLOBALS['TBE_STYLES']['htmlTemplates']['EXT:backend/Resources/Private/Templates/login.html']
This does not seem to work anymore cause of the Fluid rendering atm.
Please add signals for modifying the view object to make the login screen extendable again.
Files
Updated by Frank Nägler over 9 years ago
- Status changed from New to Needs Feedback
Hello Benjmain,
thanks for your feedback. Please can you explain why you need this?
Updated by Benjamin Serfhos over 9 years ago
So people can have their own option besides the regular option (LDAP or any other system).
For our internal colleagues we have our own generic SSO, but for external they can use the default TYPO3 environment.
See screenshot for our TYPO3 mainscreen (7.1).
Updated by Torben Hansen over 9 years ago
The template must be overridable, so you can use other authentication services (e.g. two factor) with the TYPO3 backend login, which require extra fields (example: http://typo3.org/extensions/repository/view/sf_yubikey)
Before #65939, you could override the template by using:
$TBE_STYLES['htmlTemplates']['EXT:backend/Resources/Private/Templates/login.html'] = 'path/To/NewTemplate.html';
Now it is not possible any more.
This problem can easily be solved, if the new login controller respects the template set in TBE_STYLES. The main function could be extended as shown below.
$template = 'EXT:backend/Resources/Private/Templates/Login.html'; if (isset($GLOBALS['TBE_STYLES']['htmlTemplates']['EXT:backend/Resources/Private/Templates/login.html']) && file_exists($GLOBALS['TBE_STYLES']['htmlTemplates']['EXT:backend/Resources/Private/Templates/login.html'])) { $template = $GLOBALS['TBE_STYLES']['htmlTemplates']['EXT:backend/Resources/Private/Templates/login.html']; } $view = $this->getFluidTemplateObject($template);
I'll create a patch for this change.
Updated by Gerrit Code Review over 9 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39192
Updated by Benjamin Serfhos over 9 years ago
Hi Torben,
I would suggest to use signals instead of the globals template configuration.
If you can change the view object you can add own variables too.
Kind regards,
Benjamin
Updated by Torben Hansen over 9 years ago
Hi Benjamin,
yes, that would indeed be an option / a better solution.
What I'm missing here is a note, that the TBE_STYLES have been deprecated for the loginController. The only thing I could find is was this note about the backend login form:
As not taking TBE_STYLES into respect is a breaking change, there should be a fallback / replacement for it. Also (if there is no fallback for TBE_STYLES), it should be noted as a breaking change, since I believe there are some extensions out there using TBE_STYLES to add a custom loginform.
Best regards
Torben
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Frank Nägler over 9 years ago
- Target version changed from 7.2 (Frontend) to 7.3 (Packages)
- Sprint Focus set to Stabilization Sprint
Updated by Gerrit Code Review over 9 years ago
Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Gerrit Code Review over 9 years ago
Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39234
Updated by Frank Nägler over 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset 9099b64c6a6a4d1d8dfee7665a51cb5203aedf9e.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed